Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878297 - net-dns/knot-3.2.1-r1 - libknot/.../quic.c: error: ngtcp2_settings has no member named max_udp_payload_size
Summary: net-dns/knot-3.2.1-r1 - libknot/.../quic.c: error: ngtcp2_settings has no mem...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Pierre-Olivier Mercier
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-10-25 17:50 UTC by Toralf Förster
Modified: 2022-11-01 17:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,20.63 KB, text/plain)
2022-10-25 17:50 UTC, Toralf Förster
Details
emerge-history.txt.bz2 (emerge-history.txt.bz2,84.03 KB, application/x-bzip)
2022-10-25 17:50 UTC, Toralf Förster
Details
environment (environment,84.84 KB, text/plain)
2022-10-25 17:50 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,44.34 KB, application/x-bzip)
2022-10-25 17:50 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,15.15 KB, application/x-bzip)
2022-10-25 17:50 UTC, Toralf Förster
Details
net-dns:knot-3.2.1-r1:20221025-145145.log (net-dns:knot-3.2.1-r1:20221025-145145.log,182.38 KB, text/plain)
2022-10-25 17:50 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,29.41 KB, application/x-bzip)
2022-10-25 17:50 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2022-10-25 17:50:34 UTC
  257 | int xsk_socket__fd(const struct xsk_socket *xsk);
      |     ^~~~~~~~~~~~~~
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -include ../src/config.h -DCONFIG_DIR=\"/etc/knot\" -DSTORAGE_DIR=\"/var/lib/knot\" -DRUN_DIR=\"/var/run/knot\" -DMODULE_DIR=\"\" -DMODULE_INSTDIR=\"/usr/lib64/knot/modules-3.2\" -fvisibility=hidden -I/usr/include/bpf/uapi -pipe -march=native -fno-diagnostics-color -O2 -Wall -Wshadow -Werror=format-security -Werror=implicit -Werror=attributes -Wstrict-prototypes -c libknot/xdp/quic_conn.c  -fPIC -DPIC -o libknot/xdp/.libs/la-quic_conn.o
libknot/xdp/quic.c: In function conn_new:
libknot/xdp/quic.c:648:18: error: ngtcp2_settings has no member named max_udp_payload_size; did you mean max_tx_udp_payload_size?
  648 |         settings.max_udp_payload_size = udp_pl;
      |                  ^~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop-j4-20221021-220006

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-11
 [2] x86_64-pc-linux-gnu-12 *
clang/llvm (if any):
clang version 15.0.3
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/15/bin
Configuration file: /etc/clang/clang.cfg
/usr/lib/llvm/15
15.0.3
Python 3.10.8
Available Ruby profiles:
  [1]   ruby27 (with Rubygems)
  [2]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.64.0 *
The following VMs are available for generation-2:
1)	OpenJDK 17.0.5_p5 [openjdk-17]
2)	Eclipse Temurin JDK 11.0.16.1_p1 [openjdk-bin-11]
*)	Eclipse Temurin JDK 17.0.4.1_p1 [openjdk-bin-17]
4)	Eclipse Temurin JDK 8.345_p01 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-17 
  [2]   openjdk-bin-8 
  [3]   openjdk-bin-11 
  [4]   openjdk-bin-17  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.0.2
php cli (if any):
GNU Make 4.3

  HEAD of ::gentoo
commit 4b422105857fd53b8b04b8f11c0de1fc302baa6f
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Oct 25 14:16:52 2022 +0000

    2022-10-25 14:16:52 UTC

emerge -qpvO net-dns/knot
[ebuild  N    ] net-dns/knot-3.2.1-r1  USE="dnsproxy doh geoip queryacl rrl stats synthrecord xdp -caps -cookies -dnstap -doc -fastparser -idn -libidn2 -noudp -onlinesign -systemd -utils -whoami"
Comment 1 Toralf Förster gentoo-dev 2022-10-25 17:50:35 UTC
Created attachment 825419 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2022-10-25 17:50:36 UTC
Created attachment 825421 [details]
emerge-history.txt.bz2
Comment 3 Toralf Förster gentoo-dev 2022-10-25 17:50:37 UTC
Created attachment 825423 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2022-10-25 17:50:38 UTC
Created attachment 825425 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2022-10-25 17:50:39 UTC
Created attachment 825427 [details]
logs.tar.bz2
Comment 6 Toralf Förster gentoo-dev 2022-10-25 17:50:41 UTC
Created attachment 825429 [details]
net-dns:knot-3.2.1-r1:20221025-145145.log
Comment 7 Toralf Förster gentoo-dev 2022-10-25 17:50:43 UTC
Created attachment 825431 [details]
temp.tar.bz2
Comment 8 Pierre-Olivier Mercier 2022-10-25 23:41:16 UTC
This seems to have been fixed upstream 5 days ago:

https://gitlab.nic.cz/knot/knot-dns/-/commit/b26b04c7fa4287e683c6766403a08a0b83d4c4ee

But I need to investigate as the commit doesn't suggest a bugfix.
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-25 23:44:16 UTC
(In reply to Pierre-Olivier Mercier from comment #8)
> This seems to have been fixed upstream 5 days ago:
> 
> https://gitlab.nic.cz/knot/knot-dns/-/commit/
> b26b04c7fa4287e683c6766403a08a0b83d4c4ee
> 
> But I need to investigate as the commit doesn't suggest a bugfix.

You mean it might need to be #ifdef'd?
Comment 10 Pierre-Olivier Mercier 2022-10-26 00:25:11 UTC
(In reply to Sam James from comment #9)
> (In reply to Pierre-Olivier Mercier from comment #8)
> > This seems to have been fixed upstream 5 days ago:
> > 
> > https://gitlab.nic.cz/knot/knot-dns/-/commit/
> > b26b04c7fa4287e683c6766403a08a0b83d4c4ee
> > 
> > But I need to investigate as the commit doesn't suggest a bugfix.
> 
> You mean it might need to be #ifdef'd?

No, ngtcp2 (which is embedded in knot repository) has been upgraded to 0.0.10 at the same time, 5 days ago, not in the 2.3.1. The code used in our 2.3.1 should be ngtcp2 0.0.8.

In fact, I see =net-libs/ngtcp2-0.0.10 in the emerge-history.txt. The system lib has been preferred over the embedded one.
Comment 11 Pierre-Olivier Mercier 2022-10-26 00:40:13 UTC
We missed a new USE flag "quic" starting from 3.2.0.

If it is enabled, I think we should verify net-libs/ngtcp2 is not installed, and when the 3.2.3 or 3.3 will come out, allow =net-libs/ngtcp2-0.10.0.
Comment 12 Larry the Git Cow gentoo-dev 2022-11-01 17:59:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7ba913aca3ddf5e0f2338bd0ce3df260052fb082

commit 7ba913aca3ddf5e0f2338bd0ce3df260052fb082
Author:     Pierre-Olivier Mercier <nemunaire@nemunai.re>
AuthorDate: 2022-11-01 10:51:03 +0000
Commit:     Matthew Smith <matthew@gentoo.org>
CommitDate: 2022-11-01 17:58:47 +0000

    net-dns/knot: add 3.2.2
    
    Closes: https://bugs.gentoo.org/878297
    Signed-off-by: Pierre-Olivier Mercier <nemunaire@nemunai.re>
    Signed-off-by: Matthew Smith <matthew@gentoo.org>

 net-dns/knot/Manifest          |   1 +
 net-dns/knot/knot-3.2.2.ebuild | 121 +++++++++++++++++++++++++++++++++++++++++
 net-dns/knot/metadata.xml      |   3 +
 3 files changed, 125 insertions(+)