Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878089 - media-gfx/geeqie-2.0.1-r1 build fails with USE=lcms and dev-util/xxdi: ClayRGB1998_icc.h: No such file or directory
Summary: media-gfx/geeqie-2.0.1-r1 build fails with USE=lcms and dev-util/xxdi: ClayRG...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-23 11:53 UTC by Jyrki Launonen
Modified: 2022-10-24 21:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,6.63 KB, text/plain)
2022-10-24 15:57 UTC, Jyrki Launonen
Details
build.log (geeqie-2.0.1-r1-build.log,136.48 KB, text/plain)
2022-10-24 15:59 UTC, Jyrki Launonen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jyrki Launonen 2022-10-23 11:53:58 UTC
When lcms is enabled, the build fails when compiling color-man.c on missing header even though the header should have been generated:

...
[45/177] /var/tmp/portage/media-gfx/geeqie-2.0.1-r1/work/geeqie-2.0.1/scripts/generate-ClayRGB1998-icc-h.sh ../geeqie-2.0.1/src/ClayRGB1998.icc src/ClayRGB1998_icc.h
unsigned char ClayRGB1998_icc[] = {
        0x00, 0x00, 0x02, 0x44, 0x61, 0x72, 0x67, 0x6c, 0x02, 0x20, 0x00, 0x00,
<<<snip>>>
...
[71/177] <<<snip>>>
FAILED: src/geeqie.p/color-man.c.o
x86_64-pc-linux-gnu-gcc -Isrc/geeqie.p -Isrc -I../geeqie-2.0.1/src -I. -I../geeqie-2.0.1 -Isrc/icons -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gspell-1 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/lib64/libffi/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/enchant-2 -I/usr/include/openjpeg-2.5 -I/usr/include/poppler/glib -I/usr/include/poppler -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -O0 '-DGETTEXT_PACKAGE="geeqie"' -Wno-overlength-strings -O2 -pipe -march=znver2 -pthread -MD -MQ src/geeqie.p/color-man.c.o -MF src/geeqie.p/color-man.c.o.d -o src/geeqie.p/color-man.c.o -c ../geeqie-2.0.1/src/color-man.c
../geeqie-2.0.1/src/color-man.c: In function ‘color_man_create_adobe_comp’:
../geeqie-2.0.1/src/color-man.c:75:10: fatal error: ClayRGB1998_icc.h: No such file or directory
   75 | #include "ClayRGB1998_icc.h"
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
...

The problem is, that xxdi.pl and xxd -i are not completely compatible regarding output file handling. To be specific, xxdi.pl does not support the second argument at all and will always output to stdout, which is not taken into account in the geeqie-2.0.1-allow_xxdi.patch.

Workaround is to change the last line of said patch from
+${XXD} "$(basename "$1")" "$build_dir/$2"
to
+${XXD} "$(basename "$1")" > "$build_dir/$2"
which should support both xxdi.pl and xxd -i. At least, it works with xxdi.pl.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-24 14:23:11 UTC
Please always include the full build.log and emerge --info.

Anyway, thanks for the explanation.
Comment 2 Jyrki Launonen 2022-10-24 15:57:46 UTC
Created attachment 825201 [details]
emerge --info
Comment 3 Jyrki Launonen 2022-10-24 15:59:03 UTC
Created attachment 825203 [details]
build.log
Comment 4 Bernard Cafarelli gentoo-dev 2022-10-24 21:18:35 UTC
Nice catch! Let me fix that in current ebuilds (should go upstream too) as patch was accepted
Comment 5 Larry the Git Cow gentoo-dev 2022-10-24 21:29:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92f3e7f2f6f53346dfbebd12f75b5266bbfc97d5

commit 92f3e7f2f6f53346dfbebd12f75b5266bbfc97d5
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2022-10-24 21:28:54 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-10-24 21:29:27 +0000

    media-gfx/geeqie: fix xxdi.pl support
    
    Also sync doc drop from live ebuild
    
    Closes: https://bugs.gentoo.org/878089
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 media-gfx/geeqie/files/geeqie-2.0.1-allow_xxdi.patch |  2 +-
 media-gfx/geeqie/geeqie-2.0.1-r1.ebuild              | 10 +++++-----
 media-gfx/geeqie/geeqie-9999.ebuild                  |  3 +++
 3 files changed, 9 insertions(+), 6 deletions(-)