https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: net-p2p/arti-1.0.1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 824767 [details] build.log build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN125_$LT$async_compression..futures..bufread..generic..decoder..Decoder$LT$R$C$D$GT$$u20$as$u20$futures_io..if_std..AsyncRead$GT$9poll_read17h12c36391c96ce691E+0x115): undefined reference to `ZSTD_isError' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN125_$LT$async_compression..futures..bufread..generic..decoder..Decoder$LT$R$C$D$GT$$u20$as$u20$futures_io..if_std..AsyncRead$GT$9poll_read17h12c36391c96ce691E+0x1a2): undefined reference to `ZSTD_DCtx_reset' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN125_$LT$async_compression..futures..bufread..generic..decoder..Decoder$LT$R$C$D$GT$$u20$as$u20$futures_io..if_std..AsyncRead$GT$9poll_read17h12c36391c96ce691E+0x1ae): undefined reference to `ZSTD_isError' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN97_$LT$core..future..from_generator..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17ha4ee1d2ffa8f4a49E+0x3011): undefined reference to `ZSTD_initDStream' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN97_$LT$core..future..from_generator..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17ha4ee1d2ffa8f4a49E+0x3023): undefined reference to `ZSTD_DCtx_loadDictionary' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN97_$LT$core..future..from_generator..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17ha4ee1d2ffa8f4a49E+0x302f): undefined reference to `ZSTD_isError' /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: arti.86aabb0b-cgu.0:(.text._ZN97_$LT$core..future..from_generator..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17ha4ee1d2ffa8f4a49E+0x3a41): undefined reference to `ZSTD_freeDCtx' arti.86aabb0b-cgu.0:(.text._ZN125_$LT$async_compression..futures..bufread..generic..decoder..Decoder$LT$R$C$D$GT$$u20$as$u20$futures_io..if_std..AsyncRead$GT$9poll_read17h12c36391c96ce691E+0x109): undefined reference to `ZSTD_decompressStream' arti.86aabb0b-cgu.0:(.text._ZN4core3ptr171drop_in_place$LT$async_compression..futures..bufread..ZstdDecoder$LT$futures_util..io..buf_reader..BufReader$LT$$RF$mut$u20$tor_proto..stream..data..DataStream$GT$$GT$$GT$17haac2c5949d341d59E+0x1c): undefined reference to `ZSTD_freeDCtx' arti.86aabb0b-cgu.0:(.text._ZN4core3ptr36drop_in_place$LT$zstd_safe..DCtx$GT$17h926c7dd7d5c9bdc4E+0x5): undefined reference to `ZSTD_freeDCtx' arti.86aabb0b-cgu.0:(.text._ZN4zstd14map_error_code17h9a6cefee9b962b85E+0xb): undefined reference to `ZSTD_getErrorName' arti.86aabb0b-cgu.0:(.text._ZN97_$LT$core..future..from_generator..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17ha4ee1d2ffa8f4a49E+0x2ff4): undefined reference to `ZSTD_createDCtx' error: linking with `x86_64-pc-linux-gnu-gcc` failed: exit status: 1
Seems like the issue is more with the upstream zstd crate.
Apparently fixed by cargo.eclass, cannot reproduce anymore.
Ah, thanks! I suppose it would've been this addition to src_compile: ~/gentoo/gentoo $ git blame -L519,519 eclass/cargo.eclass dc51935f7aae5 (Georgy Yakovlev 2023-02-08 16:49:47 -0800 519) filter-lto
Yes, per the See Also ticket.
