Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877545 - media-gfx/geeqie-2.0.1 without lua USE Flag still requires LUA_SINGLE_TARGET
Summary: media-gfx/geeqie-2.0.1 without lua USE Flag still requires LUA_SINGLE_TARGET
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-18 08:18 UTC by Manfred Knick
Modified: 2022-10-18 14:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manfred Knick 2022-10-18 08:18:49 UTC
me1.8 -v media-gfx/geeqie

[ebuild     U ~] media-gfx/geeqie-2.0.1::gentoo [1.7.3::gentoo] USE="djvu%* exif heif%* jpeg jpeg2k%* jpegxl%* lcms pdf raw%* spell%* tiff xmp -debug -doc -ffmpegthumbnailer -gpu-accel -lua -map -webp% -zip% (-lirc%) (-nls%*)" LUA_SINGLE_TARGET="-lua5-3 -lua5-4% (-lua5-1%*)" 2.239 KiB

evaluates to

* USE:        abi_x86_64 amd64 djvu elibc_glibc exif heif jpeg jpeg2k jpegxl kernel_linux lcms pdf raw spell tiff userland_GNU xmp
 

BUT nevertheless complains

 * No Lua implementation selected for the build. Please set
 * the LUA_SINGLE_TARGET variable in your make.conf to one
 * of the following values:
 *
 * lua5-3 lua5-4

 * ERROR: media-gfx/geeqie-2.0.1::gentoo failed (setup phase):
 *   No supported Lua implementation in LUA_SINGLE_TARGET.
 

Reproducible: Always
Comment 1 Manfred Knick 2022-10-18 10:14:48 UTC
Same applies to reduced USE set  USE="exif jpeg lcms pdf spell%* tiff" :

# emerge -pv geeqie

[ebuild     U ~] media-gfx/geeqie-2.0.1::gentoo [1.7.3::gentoo] USE="exif jpeg lcms pdf spell%* tiff -debug -djvu% -doc -ffmpegthumbnailer -gpu-accel -heif% -jpeg2k% -jpegxl% -lua -map -raw% -webp% -xmp* -zip% (-lirc%) (-nls%*)" LUA_SINGLE_TARGET="-lua5-3 -lua5-4% (-lua5-1%*)" 0 KiB
Comment 2 Bernard Cafarelli gentoo-dev 2022-10-18 11:37:34 UTC
Indeed, everything in the ebuild is hidden behind a test on USE flag, but the eclass will check for it nethertheless
This can be set per package in package.use with something like:
media-gfx/geeqie LUA_SINGLE_TARGET: lua5-4

But I will see if I can disable or conditionally run this part of the eclass
Comment 3 Manfred Knick 2022-10-18 11:42:12 UTC
MID-Air :

Just this second I was in the process to CONFIRM
when using an extended set of USE Flags:


# emerge -p -v geeqie

[ebuild   R   ~] media-gfx/geeqie-2.0.1::gentoo  USE="djvu exif heif jpeg jpeg2k jpegxl lcms lua pdf raw spell tiff xmp -debug -doc -ffmpegthumbnailer -gpu-accel -map -webp -zip" LUA_SINGLE_TARGET="lua5-4 -lua5-3" 0 KiB

works as expected.
Comment 4 Larry the Git Cow gentoo-dev 2022-10-18 14:57:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93a6d36e174bd835bd6d81f34991dd88575024b3

commit 93a6d36e174bd835bd6d81f34991dd88575024b3
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2022-10-18 14:40:28 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-10-18 14:56:09 +0000

    media-gfx/geeqie:
    
    Do not check LUA_SINGLE_TARGET with USE=-lua
    Add build option for doc
    Fix USE=map dependencies (and remove USE=gpu-accel)
    
    Closes: https://bugs.gentoo.org/877545
    Closes: https://bugs.gentoo.org/877553
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../geeqie/files/geeqie-2.0.1-doc_option.patch     | 81 ++++++++++++++++++++++
 ...{geeqie-2.0.1.ebuild => geeqie-2.0.1-r1.ebuild} | 28 +++++---
 media-gfx/geeqie/geeqie-9999.ebuild                | 32 +++++----
 media-gfx/geeqie/metadata.xml                      |  4 +-
 4 files changed, 118 insertions(+), 27 deletions(-)