Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877511 - x11-themes/ubuntu-wallpapers: Installation of malformed name tags
Summary: x11-themes/ubuntu-wallpapers: Installation of malformed name tags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords: PATCH
Depends on: 880715
Blocks:
  Show dependency tree
 
Reported: 2022-10-17 23:32 UTC by Jan Breig
Modified: 2022-11-10 09:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (rename-malformed-name-tags.diff,383 bytes, patch)
2022-10-17 23:32 UTC, Jan Breig
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Breig 2022-10-17 23:32:11 UTC
Created attachment 824639 [details, diff]
Ebuild patch

This package uses the ubuntu git repo to get the wallpapers. However these source files are not designed for distribution. Ubuntu just uses them as basis in their release process to create separate per-wallpaper packages.

The xml files installed by this package into `/usr/share/gnome-background-properties` contain malformed name tags i.e. these files contain `<_name>` instead of `<name>`. When ubuntu releases its packages, they replace these `<_name>` tags by various localized `<name>` tags.

Therefore the installed images do not show up in the gnome-control-center. Additionally, since control center version 43.0 they even trigger segmentation faults when opening the appearance panel.  
Upstream bug report: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2087

A quick fix for this would be to rename all `<_name>` tags to `<name>` (see patch file).  

Some alternatives I can think of:
- Don't install anything to `/usr/share/gnome-background-properties`  
-> This means the wallpapers will not show up in the gnome-control-center
- Use the ubuntu .deb packages in the SRC_URI  
-> This would unnecessarily increase the amount of downloaded data but would have the benefit of also supporting other languages for the image names
Comment 1 Pacho Ramos gentoo-dev 2022-10-22 22:09:34 UTC
At least with Gnome 42, the backgrounds are shown in the control center, even with the bogus <_name> entry, but I will probably go with the sedding solution :/
Comment 2 Larry the Git Cow gentoo-dev 2022-10-23 16:17:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c94f01e5d61bebf24849ca93c7eeb376dae4b91

commit 1c94f01e5d61bebf24849ca93c7eeb376dae4b91
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-10-23 15:46:51 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2022-10-23 16:06:43 +0000

    x11-themes/ubuntu-wallpapers: add 22.10.2
    
    Closes: https://bugs.gentoo.org/877511
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 x11-themes/ubuntu-wallpapers/Manifest              |  1 +
 .../ubuntu-wallpapers-22.10.2.ebuild               | 42 ++++++++++++++++++++++
 2 files changed, 43 insertions(+)