Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877485 - app-portage/gentoolkit: eclean-dist -d should omit layout.conf from cleaning
Summary: app-portage/gentoolkit: eclean-dist -d should omit layout.conf from cleaning
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2022-10-17 19:33 UTC by Greg Kubaryk
Modified: 2024-04-25 20:43 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Kubaryk 2022-10-17 19:33:56 UTC
Noticed this while building ripgrep since it has a lot of distfiles; emerge will attempt to grab layout.conf once per distfile. I occasionally remember to create the file on my distfile mirror, but then it gets cleaned out the next time I use 'eclean-dist -d'. It would be a nice enhancement if eclean-dist were taught to ignore that file, or as a workaround, a complement to --size-limit for files *smaller* than a certain size.

Excerpt from web server log:
192.168.1.78 - - [17/Oct/2022:15:21:52 -0400] "GET /gentoo-dist/distfiles/layout.conf HTTP/1.1" 404 256
192.168.1.78 - - [17/Oct/2022:15:21:52 -0400] "GET /gentoo-dist/distfiles/ripgrep-13.0.0.tar.gz HTTP/1.1" 200 505536
192.168.1.78 - - [17/Oct/2022:15:21:52 -0400] "GET /gentoo-dist/distfiles/layout.conf HTTP/1.1" 404 256
192.168.1.78 - - [17/Oct/2022:15:21:53 -0400] "GET /gentoo-dist/distfiles/ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz HTTP/1.1" 200 2109801
192.168.1.78 - - [17/Oct/2022:15:21:53 -0400] "GET /gentoo-dist/distfiles/layout.conf HTTP/1.1" 404 256
192.168.1.78 - - [17/Oct/2022:15:21:53 -0400] "GET /gentoo-dist/distfiles/bitflags-1.2.1.crate HTTP/1.1" 200 16745
[several dozen similar lines omitted]
Comment 1 Larry the Git Cow gentoo-dev 2024-04-25 09:04:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=271b91db8a2ae47732ebbcd1a391445a7d93f4dc

commit 271b91db8a2ae47732ebbcd1a391445a7d93f4dc
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-04-25 08:56:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-25 09:04:02 +0000

    distfiles.exclude: whitelist layout.conf
    
    Bug: https://bugs.gentoo.org/877485
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    Closes: https://github.com/gentoo/gentoolkit/pull/47
    Signed-off-by: Sam James <sam@gentoo.org>

 data/eclean/distfiles.exclude | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-04-25 20:40:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ddc5fd52dc4cabd88be41e622fc510e94230b86

commit 6ddc5fd52dc4cabd88be41e622fc510e94230b86
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-25 20:39:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-25 20:39:33 +0000

    app-portage/gentoolkit: add 0.6.6
    
    Closes: https://bugs.gentoo.org/877485
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/Manifest                |   1 +
 app-portage/gentoolkit/gentoolkit-0.6.6.ebuild | 127 +++++++++++++++++++++++++
 2 files changed, 128 insertions(+)