Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877449 - net-libs/libnetconf2-2.1.11 fails tests (lto): 11 - test_client_ssh (Failed)
Summary: net-libs/libnetconf2-2.1.11 fails tests (lto): 11 - test_client_ssh (Failed)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jakov Smolić
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-10-17 13:39 UTC by Agostino Sarubbo
Modified: 2024-03-26 12:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,101.03 KB, text/plain)
2022-10-17 13:39 UTC, Agostino Sarubbo
Details
1-LastTest.log (1-LastTest.log,24.81 KB, text/plain)
2022-10-17 13:39 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-10-17 13:39:26 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/libnetconf2-2.1.11 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-10-17 13:39:30 UTC
Created attachment 824597 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-10-17 13:39:31 UTC
Created attachment 824599 [details]
1-LastTest.log

1-LastTest.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-10-17 13:39:33 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


	  8 - test_server_thread (Failed)
	 11 - test_client_ssh (Failed)
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
Comment 4 Eli Schwartz gentoo-dev 2024-03-25 15:26:21 UTC
Updating to upstream 3.0.8 does NOT help as that version fails to compile instead.
Comment 5 Larry the Git Cow gentoo-dev 2024-03-26 12:31:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9dc2b0c59ee947b470757ffc8d62c0f85a4b1f84

commit 9dc2b0c59ee947b470757ffc8d62c0f85a4b1f84
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-25 15:29:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-26 12:24:30 +0000

    net-libs/libnetconf2: mark as LTO-unsafe
    
    It fails tests which seems like a promising sign that something
    unpromising happened.
    
    Closes: https://bugs.gentoo.org/877449
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/libnetconf2/libnetconf2-2.1.31.ebuild | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)