Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877207 - linux-mod.eclass: wrong option "-n" for pigz
Summary: linux-mod.eclass: wrong option "-n" for pigz
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-15 12:32 UTC by Michael Hofmann
Modified: 2022-10-15 13:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hofmann 2022-10-15 12:32:44 UTC
/var/db/repos/gentoo/eclass/linux-mod.eclass contains the line:

  pigz -n$(makeopts_jobs) ${modulename}.${KV_OBJ}

Option "-n" is wrong because... 
- option "-n" does NOT specify the number of parallel jobs
- option "-n" does NOT take an argument. 
- $(makeopts_jobs) is interpreted as the compressions level (which is not what we want) 
- pigz fails if makeopts_jobs > 11, because the maximum compression level is 11

Solution: either omit option "-n" or use option "-p", which specifies the maximum number of processes.

See: https://forums.gentoo.org/viewtopic-p-8753121.html#8753121
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-15 12:56:33 UTC
It should indeed be -p and I thought I'd fixed that. I'll do so shortly.
Comment 2 Larry the Git Cow gentoo-dev 2022-10-15 12:58:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2cac2a01d770fa260b20696f7ebb378141607cd5

commit 2cac2a01d770fa260b20696f7ebb378141607cd5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-15 12:58:10 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-15 12:58:10 +0000

    linux-mod.eclass: fix pigz threads argument
    
    I'm sorry, I thought I'd caught this before.
    
    Closes: https://bugs.gentoo.org/877207
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/linux-mod.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)