Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 877077 - net-libs/glib-networking-2.74.0 fails tests with net-libs/gnutls-3.7.8: 6 connection-gnutls-tls1.2 FAIL
Summary: net-libs/glib-networking-2.74.0 fails tests with net-libs/gnutls-3.7.8: 6 con...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2022-10-14 06:59 UTC by Agostino Sarubbo
Modified: 2022-12-02 03:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,89.80 KB, text/plain)
2022-10-14 06:59 UTC, Agostino Sarubbo
Details
1-testlog.txt (1-testlog.txt,20.40 KB, text/plain)
2022-10-14 06:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-10-14 06:59:39 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-libs/glib-networking-2.74.0 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-10-14 06:59:42 UTC
Created attachment 824021 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-10-14 06:59:43 UTC
Created attachment 824023 [details]
1-testlog.txt

1-testlog.txt
Comment 3 Alfred Wingate 2022-11-05 03:22:39 UTC
This issue is probably the upstream bug https://gitlab.gnome.org/GNOME/glib-networking/-/issues/201 which is caused by net-libs/gnutls-3.7.8 instead of lto.

There is already a fix merged upstream and it should be fixed next release.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-11-05 03:35:25 UTC
(In reply to Alfred Wingate from comment #3)
> This issue is probably the upstream bug
> https://gitlab.gnome.org/GNOME/glib-networking/-/issues/201 which is caused
> by net-libs/gnutls-3.7.8 instead of lto.
> 
> There is already a fix merged upstream and it should be fixed next release.

Thanks!
Comment 5 Larry the Git Cow gentoo-dev 2022-12-02 03:30:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=161af48a5a8d86be95b1a07f4877a0dbc8df1db3

commit 161af48a5a8d86be95b1a07f4877a0dbc8df1db3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-02 03:27:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-02 03:27:33 +0000

    net-libs/glib-networking: fix tests w/ gnutls 3.7.8
    
    Closes: https://bugs.gentoo.org/877077
    Signed-off-by: Sam James <sam@gentoo.org>

 ...lib-networking-2.74.0-gnutls-tls-1.3-test.patch | 85 ++++++++++++++++++++++
 .../glib-networking/glib-networking-2.74.0.ebuild  |  4 +
 2 files changed, 89 insertions(+)