Noticed because of discussion at https://forums.gentoo.org/viewtopic-p-8751925.html#8751925. The build log is not very verbose: ``` PLATFORM ?| Linux ARCH ?| amd64 CXX ?| x86_64-pc-linux-gnu-g++ (12.2.1) THREADS :| 32 REQFLAGS !| -std=c++20 WARNFLAGS :| -Wall -Wextra -pedantic OPTFLAGS :| LDCXXFLAGS :| -pthread -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -fexceptions -fstack-clash-protection -fcf-protection -fstack-protector CXXFLAGS +| $(REQFLAGS) $(LDCXXFLAGS) $(OPTFLAGS) $(WARNFLAGS) LDFLAGS +| $(LDCXXFLAGS) $(OPTFLAGS) $(WARNFLAGS) Building btop++ (v1.2.12) Linux amd64 Compiling src/btop_config.cpp Compiling src/btop_draw.cpp Compiling src/btop.cpp Compiling src/btop_input.cpp Compiling src/btop_shared.cpp Compiling src/btop_menu.cpp Compiling src/linux/btop_collect.cpp Compiling src/btop_tools.cpp Compiling src/btop_theme.cpp <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_tools.o (3.7MiB) (06s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_input.o (3.8MiB) (06s) 90% -> obj/btop_theme.o (3.9MiB) (06s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_config.o (3.9MiB) (07s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_shared.o (4.8MiB) (08s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop.o (5.1MiB) (08s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_menu.o (6.3MiB) (11s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/linux/btop_collect.o (9.2MiB) (14s) <command-line>: warning: "_FORTIFY_SOURCE" redefined <built-in>: note: this is the location of the previous definition 90% -> obj/btop_draw.o (8.3MiB) (14s) Linking and optimizing binary... 100% -> bin/btop (29MiB) (00s) Build complete in (16s) >>> Source compiled. >>> Test phase [not enabled]: sys-process/btop-1.2.12 ``` Upstream silence various compiler invocations with '@' (https://github.com/aristocratos/btop/blob/main/Makefile#L265). Could we patch those out please?
(In reply to Sam James from comment #0) > Upstream silence various compiler invocations with '@' > (https://github.com/aristocratos/btop/blob/main/Makefile#L265). > > Could we patch those out please? I'll ask upstream if they can add a verbose mode first. This might be useful for other distros and build pipelines, too.
(In reply to Adrian Schollmeyer from comment #1) > I'll ask upstream if they can add a verbose mode first. > This might be useful for other distros and build pipelines, too. Upstream issue opened, #442
Upstream now supports setting `VERBOSE=true` to show the build commands. I'll backport it to our versions.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b07006fc3f1e69ec7f4605b6b2caffb985658431 commit b07006fc3f1e69ec7f4605b6b2caffb985658431 Author: Adrian Schollmeyer <nex+b-g-o@nexadn.de> AuthorDate: 2022-10-10 10:59:09 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-10-10 11:44:30 +0000 sys-process/btop: Make build output verbose The build system didn't support verbose output before (i.e. it didn't show the exact commands used to build a unit). Upstream recently added such a verbose mode, which is backported to the current versions in ::gentoo by this commit. Closes: https://bugs.gentoo.org/876319 Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de> Closes: https://github.com/gentoo/gentoo/pull/27725 Signed-off-by: Sam James <sam@gentoo.org> sys-process/btop/btop-1.2.12.ebuild | 6 ++- sys-process/btop/btop-1.2.9.ebuild | 6 ++- .../btop/files/876319-verbose-makefile.patch | 54 ++++++++++++++++++++++ 3 files changed, 64 insertions(+), 2 deletions(-)
