Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 876241 - app-metrics/node_exporter: add --collector.textfile.directory argument to systemd service
Summary: app-metrics/node_exporter: add --collector.textfile.directory argument to sys...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-10-09 00:55 UTC by John Helmert III
Modified: 2022-10-14 17:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-10-09 00:55:35 UTC 
The init file has:

command_args="${command_args:---collector.textfile.directory=/var/lib/node_exporter/}"

The confd file has:

command_args="--collector.textfile.directory=/var/lib/node_exporter/"

However, the systemd service executes the program without arguments:

ExecStart=/usr/sbin/node_exporter
Comment 1 Larry the Git Cow gentoo-dev 2022-10-14 17:20:00 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57815e3bae0ad8bb6658fd2754732cc51f52a430

commit 57815e3bae0ad8bb6658fd2754732cc51f52a430
Author:     John Helmert III <ajak@gentoo.org>
AuthorDate: 2022-10-14 17:18:28 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2022-10-14 17:19:49 +0000

    app-metrics/node_exporter: add 1.4.0
    
    Closes: https://bugs.gentoo.org/876241
    Closes: https://github.com/gentoo/gentoo/27701
    Signed-off-by: John Helmert III <ajak@gentoo.org>
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 app-metrics/node_exporter/Manifest                 |  2 +
 .../node_exporter/files/node_exporter.initd-1      | 23 +++++++++++
 .../node_exporter/files/node_exporter.service-1    | 13 +++++++
 .../node_exporter/node_exporter-1.4.0.ebuild       | 45 ++++++++++++++++++++++
 4 files changed, 83 insertions(+)