https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: media-libs/x265-3.5-r2 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 822733 [details] build.log.xz build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Error(s) that match a know pattern in addition to what has been reported in the summary: FAILED: libx265.so.199 FAILED: test/TestBench /var/tmp/portage/media-libs/x265-3.5-r2/work/x265_3.5/source/./x265.h:193:16: error: type ‘struct x265_analysis_distortion_data’ violates the C++ One Definition Rule [-Werror=odr]
reproducible with =media-libs/x265-3.5-r3
lto_tinderbox has reproduced this issue with version 3.5-r3 - Updating summary.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7da321dd9f1964ad1f3534fb09edbce0fd0d397 commit b7da321dd9f1964ad1f3534fb09edbce0fd0d397 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-18 06:14:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-18 07:20:20 +0000 media-libs/x265: mark as LTO-unsafe Closes: https://bugs.gentoo.org/875854 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> media-libs/x265/x265-3.5-r3.ebuild | 9 +++++++-- media-libs/x265/x265-9999.ebuild | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-)
