Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 873769 - sys-apps/flashrom: update dependency to virtual/libusb:1?
Summary: sys-apps/flashrom: update dependency to virtual/libusb:1?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-01 03:36 UTC by Sam James
Modified: 2022-10-02 21:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-10-01 03:36:31 UTC
Does flashrom still need libusb 0.x (virtual/libusb:0)?

It looks like it might support libusb 1 as of 2016: https://github.com/flashrom/flashrom/commit/e49edbb8989abe206d144e4ae7bc9f7ae636bada.

Please update the dep in a new revision to virtual/libusb:1 if it works.
Comment 1 Marek Szuba archtester gentoo-dev 2022-10-02 20:48:49 UTC
Given only a single programmer still requires virtual/libusb:0, I am aretty sure this has been an omission. Will double-check just to be sure, though.
Comment 2 Larry the Git Cow gentoo-dev 2022-10-02 21:06:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=673fdc1be76c120e36829af338a4c43d84ead765

commit 673fdc1be76c120e36829af338a4c43d84ead765
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-10-02 20:54:12 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-10-02 21:06:30 +0000

    sys-apps/flashrom: do not depend on virtual/libusb:0
    
    There was only a single programmer which still depended on that version
    of libusb, and it builds fine against virtual/libusb:1. In fact, even
    before this change upstream build scripts happily ignored libusb-0 and
    only linked against libusb-1 even with pickit2-spi support enabled!
    
    Straight-to-stable revbump because as mentioned above, the dependency in
    question was not actually used.
    
    Closes: https://bugs.gentoo.org/873769
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 sys-apps/flashrom/{flashrom-1.2-r3.ebuild => flashrom-1.2-r4.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)