Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 873685 - sci-geosciences/gnome-maps-43.0: drop unused dependencies
Summary: sci-geosciences/gnome-maps-43.0: drop unused dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 18:18 UTC by Johannes Penßel
Modified: 2022-10-12 02:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Penßel 2022-09-30 18:18:39 UTC
Version 43.0 of gnome maps has had many of its dependencies removed and replaced with GTK4 / libshumate implementations. This includes:

gnome-online-accounts
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/5fe53d637a7609951dcf6f1fb3aa5d3e4499a623
libgfbgraph
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/919c099b37fa758650400110d2d986169916eba7
webkit-gtk
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/021500439e30d9c371d1a1c4aabf7eff323245b7
geocode-glib
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/96d9842207a9dbee1d4d1e8293b064f39d15808a
clutter / clutter-gtk
https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/99256e1a10da116275d22cf2541935f9570b88e3

In my own tests, the build process without these dependencies installed worked just fine.

Please update the ebuild accordingly, so the application doesn't pull in a bunch of useless stuff. Thanks!
Comment 1 Matt Turner gentoo-dev 2022-09-30 20:30:38 UTC
Oh, you're right. Looks like in v42:

# grep -r 'imports.gi' * | wc -l
285

but in v43:

# grep -r 'imports.gi' * | wc -l
1
Comment 2 Larry the Git Cow gentoo-dev 2022-09-30 20:37:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5446f3d8a6150f9805122ca712375d880b48da2

commit a5446f3d8a6150f9805122ca712375d880b48da2
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-09-30 20:33:16 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-09-30 20:36:55 +0000

    sci-geosciences/gnome-maps: Drop unneeded dependencies
    
    Closes: https://bugs.gentoo.org/873685
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 sci-geosciences/gnome-maps/gnome-maps-43.0.ebuild | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
Comment 3 John Wudrick 2022-10-01 00:26:44 UTC
Maps migrated to using ES6 modules for 43, GI imports look like this now:

import Foo from 'gi://Foo';

Build fails unless libsecret, graphene, libsoup:3.0, pango, and libshumate all have [introspection].

Also, there's a dependency bug in meson.build, shumate dep is 1.0.0.beta which meson treats as > 1.0.0, adding this to src_prepare fixes it:

sed -i '/shumate/s/.beta//' meson.build
Comment 4 John Wudrick 2022-10-01 04:22:46 UTC
Disregard this part, using libshumate 1.0.1 avoids this issue.

> 
> Also, there's a dependency bug in meson.build, shumate dep is 1.0.0.beta
> which meson treats as > 1.0.0, adding this to src_prepare fixes it:
> 
> sed -i '/shumate/s/.beta//' meson.build
Comment 5 John Wudrick 2022-10-01 04:29:30 UTC
But libshumate dep in maps ebuild should be bumped to 1.0.1 just to be on the safe side.
Comment 6 Matt Turner gentoo-dev 2022-10-12 02:36:18 UTC
(In reply to John Wudrick from comment #3)
> Maps migrated to using ES6 modules for 43, GI imports look like this now:
> 
> import Foo from 'gi://Foo';
> 
> Build fails unless libsecret, graphene, libsoup:3.0, pango, and libshumate
> all have [introspection].

Thanks. Let me fix this.
Comment 7 Matt Turner gentoo-dev 2022-10-12 02:44:51 UTC
(In reply to Johannes Penßel from comment #0)
> Version 43.0 of gnome maps has had many of its dependencies removed and
> replaced with GTK4 / libshumate implementations. This includes:
> 
> gnome-online-accounts
> https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/
> 5fe53d637a7609951dcf6f1fb3aa5d3e4499a623
> libgfbgraph
> https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/
> 919c099b37fa758650400110d2d986169916eba7
> webkit-gtk
> https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/
> 021500439e30d9c371d1a1c4aabf7eff323245b7
> geocode-glib
> https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/
> 96d9842207a9dbee1d4d1e8293b064f39d15808a

I see

> src/application.js:import Geocode from 'gi://GeocodeGlib';
> src/location.js:import Geocode from 'gi://GeocodeGlib';
> src/main.js:import 'gi://GeocodeGlib?version=2.0';


so I think we need geocode-glib[introspection].

> clutter / clutter-gtk
> https://gitlab.gnome.org/GNOME/gnome-maps/-/commit/
> 99256e1a10da116275d22cf2541935f9570b88e3

(In reply to John Wudrick from comment #5)
> But libshumate dep in maps ebuild should be bumped to 1.0.1 just to be on
> the safe side.

Not planning to bother with this. v1.0.1 is the first version we have in Gentoo.
Comment 8 Larry the Git Cow gentoo-dev 2022-10-12 02:47:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b00b7dad14e4462ce51bd2f986571c8eb0145f3d

commit b00b7dad14e4462ce51bd2f986571c8eb0145f3d
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2022-10-12 02:45:57 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-10-12 02:46:43 +0000

    sci-geosciences/gnome-maps: Fix introspection dependencies
    
    Closes: https://bugs.gentoo.org/873685
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 sci-geosciences/gnome-maps/gnome-maps-43.0.ebuild | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)