Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 873157 - app-emulation/qemu-7.1.0: build fails with USE=capstone
Summary: app-emulation/qemu-7.1.0: build fails with USE=capstone
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: John Helmert III
URL:
Whiteboard:
Keywords:
: 873334 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-27 09:48 UTC by Kai-Chun Ning
Modified: 2022-09-28 16:42 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
meson build log (meson-log.txt,179.13 KB, text/plain)
2022-09-27 09:48 UTC, Kai-Chun Ning
Details
build log (build.log,17.09 KB, text/plain)
2022-09-27 09:49 UTC, Kai-Chun Ning
Details
capstone info (capstone.log,847 bytes, text/plain)
2022-09-27 09:49 UTC, Kai-Chun Ning
Details
capstone info (capstone.log,2.04 KB, text/plain)
2022-09-27 09:53 UTC, Kai-Chun Ning
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai-Chun Ning 2022-09-27 09:48:31 UTC
Created attachment 814333 [details]
meson build log

meson dependency check fails with USE=capstone. Please see meson-log.txt for details.
Comment 1 Kai-Chun Ning 2022-09-27 09:49:07 UTC
Created attachment 814336 [details]
build log
Comment 2 Kai-Chun Ning 2022-09-27 09:49:29 UTC
Created attachment 814339 [details]
capstone info
Comment 3 Kai-Chun Ning 2022-09-27 09:53:43 UTC
Created attachment 814342 [details]
capstone info
Comment 4 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-09-27 16:54:31 UTC
(erroneously commented in bug 873190 first)

https://gitlab.com/qemu-project/qemu/-/blob/master/meson.build#L2611

So it's checking for capstone, but dies if it's not accessible via `#include <capstone.h>`, but I think it should simply find the right include dir at configure time then specify it via -I on the compiler command line?
Comment 5 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-09-27 17:05:34 UTC
The capstone include dir is arguably incorrect (should be /usr/include/capstone), but it's been that way for a while and reverse dependencies are already starting to adjust so I'm not sure if it's worth the effort to fix everything again.

QEMU is already including capstone/capstone.h via a patch, so it's just the meson check that's failing. I suppose we should just drop the failing check in Gentoo, but it's been there since 6.1.0 so I'm not sure how we've not hit it before.
Comment 6 Larry the Git Cow gentoo-dev 2022-09-27 17:31:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9badece6035892cc705ff09dca318c5a59473ae8

commit 9badece6035892cc705ff09dca318c5a59473ae8
Author:     John Helmert III <ajak@gentoo.org>
AuthorDate: 2022-09-27 17:30:25 +0000
Commit:     John Helmert III <ajak@gentoo.org>
CommitDate: 2022-09-27 17:31:02 +0000

    app-emulation/qemu: fix configure failure with USE=capstone
    
    Closes: https://bugs.gentoo.org/873157
    Signed-off-by: John Helmert III <ajak@gentoo.org>

 .../files/qemu-7.1.0-capstone-include-path.patch   | 31 ++++++++++++++++++++++
 app-emulation/qemu/qemu-7.1.0.ebuild               |  2 +-
 2 files changed, 32 insertions(+), 1 deletion(-)
Comment 7 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-09-28 16:42:47 UTC
*** Bug 873334 has been marked as a duplicate of this bug. ***