Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 872992 - dev-util/babeltrace-1.5.8 fails tests
Summary: dev-util/babeltrace-1.5.8 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 759754
  Show dependency tree
 
Reported: 2022-09-26 08:51 UTC by Agostino Sarubbo
Modified: 2023-12-19 05:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,199.02 KB, text/plain)
2022-09-26 08:51 UTC, Agostino Sarubbo
Details
1-test-suite.log (1-test-suite.log,24.23 KB, text/plain)
2022-09-26 08:51 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-26 08:51:48 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/babeltrace-1.5.8 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-26 08:51:50 UTC
Created attachment 814198 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-26 08:51:51 UTC
Created attachment 814201 [details]
1-test-suite.log

1-test-suite.log
Comment 3 Agostino Sarubbo gentoo-dev 2022-09-26 08:51:53 UTC
Error(s) that match a know pattern:


FAIL: bin/intersection/test_intersection 1 - 8 events in the whole trace
FAIL: bin/intersection/test_intersection 2 - 3 events in packets intersecting
FAIL: bin/intersection/test_intersection 3 - 8 events in the whole trace
FAIL: bin/intersection/test_intersection 4 - 3 events in packets intersecting
FAIL: bin/intersection/test_intersection 5 - 6 events in the whole trace
FAIL: bin/intersection/test_intersection 7 - 3 events in the whole trace
FAIL: bin/intersection/test_intersection 8 - 3 events in packets intersecting
FAIL: bin/test_packet_seq_num 1 - Trace parses
FAIL: bin/test_packet_seq_num 10 - Lost events string matches 3,2,1
FAIL: bin/test_packet_seq_num 3 - Trace parses
FAIL: bin/test_packet_seq_num 5 - Trace parses
FAIL: bin/test_packet_seq_num 6 - Lost events string matches 2
FAIL: bin/test_packet_seq_num 7 - Trace parses
FAIL: bin/test_packet_seq_num 8 - Lost events string matches 2
FAIL: bin/test_packet_seq_num 9 - Trace parses
FAIL: bin/test_trace_read 1 - Run babeltrace with trace env-warning
FAIL: bin/test_trace_read 10 - Run babeltrace with trace wk-heartbeat-u
FAIL: bin/test_trace_read 2 - Run babeltrace with trace lttng-modules-2.0-pre5
FAIL: bin/test_trace_read 3 - Run babeltrace with trace sequence
FAIL: bin/test_trace_read 4 - Run babeltrace with trace smalltrace
FAIL: bin/test_trace_read 5 - Run babeltrace with trace succeed1
FAIL: bin/test_trace_read 6 - Run babeltrace with trace succeed2
FAIL: bin/test_trace_read 7 - Run babeltrace with trace succeed3
FAIL: bin/test_trace_read 8 - Run babeltrace with trace succeed4
FAIL: bin/test_trace_read 9 - Run babeltrace with trace warnings
FAIL: lib/test_ctf_writer_complete 95 - Babeltrace could read the resulting trace
Comment 4 matoro archtester 2023-11-29 03:17:01 UTC
Not LTO-specific
Comment 5 Larry the Git Cow gentoo-dev 2023-12-19 05:26:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6f136bbc813ef7a65358e7f5712a3d49395d717

commit f6f136bbc813ef7a65358e7f5712a3d49395d717
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2023-12-14 19:21:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-19 05:25:52 +0000

    dev-util/babeltrace: add 2.0.5
    
    Closes: https://bugs.gentoo.org/872992
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Closes: https://github.com/gentoo/gentoo/pull/34286
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-util/babeltrace/Manifest                |  1 +
 dev-util/babeltrace/babeltrace-2.0.5.ebuild | 56 +++++++++++++++++++++++++++++
 dev-util/babeltrace/metadata.xml            |  7 ++++
 3 files changed, 64 insertions(+)