Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 872581 - net-libs/webkit-gtk-2.38.0: new version with optional PDF.js support
Summary: net-libs/webkit-gtk-2.38.0: new version with optional PDF.js support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://www.webkitgtk.org/2022/09/16/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-24 00:29 UTC by Michael Orlitzky
Modified: 2022-09-27 15:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2022-09-24 00:29:45 UTC
I know that the Gnome team is already aware of this as part of Gnome 43, but I'm opening this to ask for a new USE flag that controls PDF.js as part of the update.

Disabling PDF.js in webkit-gtk-2.38.x was suggested to me as the eventually-solution to treating PDF files like any other download in epiphany:

  https://gitlab.gnome.org/GNOME/epiphany/-/issues/1750

Passing -DENABLE_PDFJS=ON/OFF to the build should do it.
Comment 1 Matt Turner gentoo-dev 2022-09-24 01:44:25 UTC
Are you going to flip out if we enable it by default?
Comment 2 Michael Orlitzky gentoo-dev 2022-09-24 03:56:34 UTC
(In reply to Matt Turner from comment #1)
> Are you going to flip out if we enable it by default?

Per-package defaults was my preferred solution to that problem, so no, unless you intend to enable it for every package on every profile by adding USE=pdf to profiles/base/make.defaults.

Of course I think it should be off by default though. There's no justification for overriding a user's clear indication that he doesn't want PDF support sans USE=pdf.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-27 15:44:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8747e6c1a862216a909e3e3ff9d76171324723d7

commit 8747e6c1a862216a909e3e3ff9d76171324723d7
Author:     brahmajit das <listout@protonmail.com>
AuthorDate: 2022-09-27 13:52:32 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-09-27 15:36:52 +0000

    net-libs/webkit-gtk: Version bump to 2.38.0
    
    The slotting is to handle libsoup3 and libsoup2. Some packages from
    GNOME 43 are requiring webkit2gtk-4.1 (gtk3 with libsoup3), for example
    GNOME boxes.
    
    Closes: https://bugs.gentoo.org/872581
    Closes: https://github.com/gentoo/gentoo/pull/27357
    Signed-off-by: brahmajit das <listout@protonmail.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 net-libs/webkit-gtk/Manifest                      |   1 +
 net-libs/webkit-gtk/webkit-gtk-2.38.0-r410.ebuild | 259 ++++++++++++++++++++++
 net-libs/webkit-gtk/webkit-gtk-2.38.0.ebuild      | 249 +++++++++++++++++++++
 3 files changed, 509 insertions(+)