Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 872224 - app-mobilephone/scrcpy-1.24: missing dependency on android-tools
Summary: app-mobilephone/scrcpy-1.24: missing dependency on android-tools
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 16:18 UTC by Louis Leseur
Modified: 2022-10-17 15:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Louis Leseur 2022-09-21 16:18:16 UTC
When running scrcpy, I get this output:

$ scrcpy -Vdebug
scrcpy 1.24 <https://github.com/Genymobile/scrcpy>
exec: No such file or directory
ERROR: Command not found: [adb], [start-server]
ERROR: (make 'adb' accessible from your PATH or define its fullpath in the ADB environment variable)
INFO: You may install 'adb' by "apt install adb"
ERROR: Could not execute "adb start-server"
ERROR: Could not start adb daemon
ERROR: Server connection failed


I believe the package is missing a runtime dependency on dev-util/android-tools to provide adb.
Comment 1 Bernard Cafarelli gentoo-dev 2022-10-09 20:36:45 UTC
Thanks for the report!

I have always use dev-util/android-sdk-update-manager to get android platform tools, which requires manual steps to get them (so I did not add to dependencies).

Using dev-util/android-tools is a much cleaner solution, fixing the ebuild
Comment 2 Bernard Cafarelli gentoo-dev 2022-10-17 14:59:19 UTC
Dropping keyword dependency, ppc64 will need manual install of adb for now
Comment 3 Larry the Git Cow gentoo-dev 2022-10-17 15:00:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26559769503220880e0318120c8951fb256d638e

commit 26559769503220880e0318120c8951fb256d638e
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2022-10-17 14:59:43 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-10-17 15:00:31 +0000

    app-mobilephone/scrcpy: depend on dev-util/android-tools when possible
    
    ppc64 will need bug #723528 fixed first
    
    Closes: https://bugs.gentoo.org/872224
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../scrcpy/{scrcpy-1.24.ebuild => scrcpy-1.24-r1.ebuild}            | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)