Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 872176 - dev-util/gitlab-runner-15.3.0 uses wrong git hash
Summary: dev-util/gitlab-runner-15.3.0 uses wrong git hash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL: https://gitlab.com/gitlab-org/gitlab-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-21 08:51 UTC by Stephan Lukasczyk
Modified: 2022-09-24 19:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Lukasczyk 2022-09-21 08:51:15 UTC
Installing dev-util/gitlab-runner-15.3.0 on an amd64 machine works like a charm, however, when registering it to GitLab, the executions run into failures.  I've already filed an issue with GitLab (see https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29296), they pointed me to the fact that the EBUILD (https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/gitlab-runner/gitlab-runner-15.3.0.ebuild) for the package contains a wrong commit hash in line 8, which states “bbcb5aba7”, whereas the expected hash should be “bbcb5aba”.

This causes a failure as the gitlab-runner-helper image cannot be pulled (see my issue with GitLab).

Reproducible: Always

Steps to Reproduce:
1. Install dev-util/gitlab-runner-15.3.0
2. Register it using the Docker subsystem in a GitLab instance
3. Experience failures in GitLab's CI due to the fact that the gitlab-runner-helper image could not be retrieved
Actual Results:  
Build failures due to gitlab-runner-helper image not available for the given git hash.

Expected Results:  
No errors in GitLab CI.

As stated in my GitLab issue (https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29296), one can work around the problem by specifying the `helper_image = registry.gitlab.com/gitlab-org/gitlab-runner/gitlab-runner-helper:x86_64-bbcb5aba` in `/etc/gitlab-runner/config.toml`.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-21 09:20:29 UTC
I suggest making the ebuild take the full hash and then truncate it to the needed number of characters later to avoid problems. It's what I do in mine which need this.
Comment 2 Larry the Git Cow gentoo-dev 2022-09-24 19:09:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1094ba119eec76b1bd46980fe47ba2482b52dc5

commit f1094ba119eec76b1bd46980fe47ba2482b52dc5
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2022-09-24 19:07:06 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2022-09-24 19:07:06 +0000

    dev-util/gitlab-runner: add 15.3.1
    
    Closes: https://bugs.gentoo.org/872176
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 dev-util/gitlab-runner/Manifest                    |  2 +
 dev-util/gitlab-runner/gitlab-runner-15.3.1.ebuild | 67 ++++++++++++++++++++++
 2 files changed, 69 insertions(+)