Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 871339 - Very low quality commits to dev-python/jarowinkler and dev-python/rapidfuzz
Summary: Very low quality commits to dev-python/jarowinkler and dev-python/rapidfuzz
Status: RESOLVED FIXED
Alias: None
Product: Quality Assurance
Classification: Unclassified
Component: Disputes/raising issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-18 12:53 UTC by Michał Górny
Modified: 2022-09-18 19:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-09-18 12:53:14 UTC
These ebuilds are the lowest quality possible.  Both use obsolete eclass mode.  Both are missing dependencies that are needed to build the C extension.

In both packages calling 'setup.py test' doesn't do anything.  Yet one ebuild claims to run tests this way, while the other one claims that tests need to be restricted because of network access (how? this command doesn't do anything useful!).

I'm reverting this.  I have worked on rapidfuzz & jarowinkler in the past, and I have ebuilds for both on a local branch.  I'm going to update them and push working ebuilds for both packages today.
Comment 1 Larry the Git Cow gentoo-dev 2022-09-18 12:55:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ca67e2237a7d3481d2f7a79f1604e82a29b3dde

commit 3ca67e2237a7d3481d2f7a79f1604e82a29b3dde
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-09-18 12:54:26 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 12:54:26 +0000

    dev-python/jarowinkler: Revert "new package, add 1.2.1"
    
    Reverts: 46e353bf3dc47d5416279828f4798bebe41cbfe2
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/jarowinkler/Manifest                 |  1 -
 dev-python/jarowinkler/jarowinkler-1.2.1.ebuild | 17 -----------------
 dev-python/jarowinkler/metadata.xml             |  7 -------
 3 files changed, 25 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ac6c60262becd1f9fd3d14e5432a388e45a48c07

commit ac6c60262becd1f9fd3d14e5432a388e45a48c07
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-09-18 12:53:47 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 12:53:47 +0000

    dev-python/rapidfuzz: Revert "new package, add 2.9.0"
    
    Reverts: cafe56242f43d96c2e69b428930d30f3b6bcbffe
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/rapidfuzz/Manifest               |  1 -
 dev-python/rapidfuzz/metadata.xml           |  7 -------
 dev-python/rapidfuzz/rapidfuzz-2.9.0.ebuild | 22 ----------------------
 3 files changed, 30 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c7f230c5b264256b213ba9c6c17571208f616a0

commit 2c7f230c5b264256b213ba9c6c17571208f616a0
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-09-18 12:43:45 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 12:53:19 +0000

    sci-chemistry/chemex: Revert "add 2022.0.1"
    
    Reverting because of pending dev-python/ deps revert.
    
    Reverts: 96ce6a9530fc93af92cad81b30dcb4059bc07063
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sci-chemistry/chemex/Manifest               |  1 -
 sci-chemistry/chemex/chemex-2022.0.1.ebuild | 48 -----------------------------
 2 files changed, 49 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2022-09-18 13:46:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88f325541fa8aa0574ec76744049e2c843083bdb

commit 88f325541fa8aa0574ec76744049e2c843083bdb
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-09-18 08:21:48 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 13:46:48 +0000

    sci-chemistry/chemex: add 2022.0.1
    
    Readding now that deps are satisfied again.
    
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 sci-chemistry/chemex/Manifest               |  1 +
 sci-chemistry/chemex/chemex-2022.0.1.ebuild | 48 +++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cee9b5214a4f1e4cc33315b04aa1075a2d1d71e8

commit cee9b5214a4f1e4cc33315b04aa1075a2d1d71e8
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-06-06 06:14:20 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 13:46:47 +0000

    dev-python/rapidfuzz: New package, v2.9.0
    
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/rapidfuzz/Manifest                      |  1 +
 .../files/rapidfuzz-2.9.0-test-pandas.patch        | 35 ++++++++++++++++
 dev-python/rapidfuzz/metadata.xml                  | 12 ++++++
 dev-python/rapidfuzz/rapidfuzz-2.9.0.ebuild        | 47 ++++++++++++++++++++++
 4 files changed, 95 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd26cedebae5f53008a68a65cc99cd50502c7217

commit bd26cedebae5f53008a68a65cc99cd50502c7217
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-06-06 06:13:22 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-09-18 13:46:46 +0000

    dev-python/jarowinkler: New package, v1.2.1
    
    Bug: https://bugs.gentoo.org/871339
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/jarowinkler/Manifest                 |  1 +
 dev-python/jarowinkler/jarowinkler-1.2.1.ebuild | 39 +++++++++++++++++++++++++
 dev-python/jarowinkler/metadata.xml             | 12 ++++++++
 3 files changed, 52 insertions(+)
Comment 3 Pacho Ramos gentoo-dev 2022-09-18 18:08:33 UTC
Sorry, I will look at your ebuilds to see
Comment 4 Pacho Ramos gentoo-dev 2022-09-18 18:55:48 UTC
OK, I have been reviewing the changes and I think I know understand better how the backends are detected and used with PEP517.

The "network" issue was probably because it was trying to download and install some of the missing deps on its own.

Sorry for the inconvenience, I see this bug is under "Disputes" component... but I didn't mean to break the rules or something like that. I simply wasn't inspired this morning and got messed up.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-09-18 19:17:53 UTC
No problem.  This seemed like the most correct component for this.