Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870181 - media-gfx/kphotoalbum-5.9.1 fails tests: 3 - TestThumbnailCache (Failed)
Summary: media-gfx/kphotoalbum-5.9.1 fails tests: 3 - TestThumbnailCache (Failed)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-15 06:46 UTC by Agostino Sarubbo
Modified: 2022-09-16 18:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,841.16 KB, text/plain)
2022-09-15 06:46 UTC, Agostino Sarubbo
Details
1-LastTest.log (1-LastTest.log,6.35 KB, text/plain)
2022-09-15 06:46 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-15 06:46:07 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/kphotoalbum-5.9.1 fails tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-15 06:46:10 UTC
Created attachment 805222 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-15 06:46:11 UTC
Created attachment 805225 [details]
1-LastTest.log

1-LastTest.log
Comment 3 Andreas Sturmlechner gentoo-dev 2022-09-15 07:06:15 UTC
Tobias, is it known to fail or supposed to work?
Comment 4 Tobias Leupold 2022-09-15 10:14:15 UTC
I'll have to look into this. I don't think that we currently have known failing tests ...
Comment 5 Tobias Leupold 2022-09-15 11:20:26 UTC
I can't confirm anything to fail on my desktop Gentoo box ...

With the checked out 5.9.1 sources, both the build process as well as all tests pass without any problem, tried both with make and ninja, combined with both g++ and clang++ ...

A normal emerge of the KPA 5.9.1 ebuild works as well.

With USE="test", interestingly, emerge wants to add x11-apps/xhost now, as well as to rebuild x11-base/xorg-server with "test" and "xvfb" set; however, this also emerges without any problem.

I can't reproduce the problem!
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-15 11:53:41 UTC
(In reply to Tobias Leupold from comment #5)
> I can't confirm anything to fail on my desktop Gentoo box ...
> 
> With the checked out 5.9.1 sources, both the build process as well as all
> tests pass without any problem, tried both with make and ninja, combined
> with both g++ and clang++ ...
> 
> A normal emerge of the KPA 5.9.1 ebuild works as well.
> 
> With USE="test", interestingly, emerge wants to add x11-apps/xhost now, as
> well as to rebuild x11-base/xorg-server with "test" and "xvfb" set; however,
> this also emerges without any problem.

USE=test does not control the test suite, just deps and building it. You need to do:
1. emerge -v1o --with-test-deps kphotoalbum
2. FEATURES=test emerge -v1 kphotoalbum
Comment 7 Tobias Leupold 2022-09-15 13:45:18 UTC
Ah, I see.

However, I don't get why portage pulls additional dependencies not present on my system, when I can make/ninja test on the sources without them ...

Anyway. Even with FEATURES="test" emerge -1v kphotoalbum I can't trigger any problem ...
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-15 13:49:46 UTC
(In reply to Tobias Leupold from comment #7)
> Ah, I see.
> 
> However, I don't get why portage pulls additional dependencies not present
> on my system, when I can make/ninja test on the sources without them ...
> 

The ebuild has VIRTUALX_REQUIRED="test" so it runs the test suite within virtx.

> Anyway. Even with FEATURES="test" emerge -1v kphotoalbum I can't trigger any
> problem ...

:(
Comment 9 Andreas Sturmlechner gentoo-dev 2022-09-15 19:43:15 UTC
(In reply to Tobias Leupold from comment #7)
> However, I don't get why portage pulls additional dependencies not present
> on my system, when I can make/ninja test on the sources without them ...
This is necessary to succeed in sandboxed nongui environments, see bug 869797
Comment 10 johannes 2022-09-15 22:21:44 UTC
Looking at the details of the log, this seems a rather surprising cause of events:

> QWARN  : KPATest::TestThumbnailCache::insertRemove() kphotoalbum.ImageManager: Thumbnail data for file "someImage.jpg" is invalid!
> FAIL!  : KPATest::TestThumbnailCache::insertRemove() Compared values are not the same
>    Actual   (thumbnailCache.size()): 0
>    Expected (1)                    : 1
>    Loc: [/var/tmp/portage/media-gfx/kphotoalbum-5.9.1/work/kphotoalbum-5.9.1/lib/kpathumbnails/TestThumbnailCache.cpp(150)]

The test code goes like this:
QImage someImage = /* create a simple image */;
QVERIFY( !someImage.isNull()); // this succeeds
thumbnailCache.insert(someImage); // this generates the QWARN log entry, caused by someImage.isNull() being true

QImage is a local object, so we know that there's nothing else invalidating it. I don't quite understand how two consecutive checks for QImage::isNull() can yield different results...
Comment 11 Andreas Sturmlechner gentoo-dev 2022-09-16 07:54:23 UTC
Note that dev-qt/qtgui has IUSE jpeg and in this tinderbox build it is disabled. It is probably nonsensical for kphotoalbum to allow dev-qt/qtgui[-jpeg] in the first place, but it might explain this test failure that no one else can reproduce.
Comment 12 Andreas Sturmlechner gentoo-dev 2022-09-16 18:34:03 UTC
Yup, that's exactly it.
Comment 13 Larry the Git Cow gentoo-dev 2022-09-16 18:36:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=e81091c00d60493f589c156fcdcd2ac907aacfe1

commit e81091c00d60493f589c156fcdcd2ac907aacfe1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-09-16 18:35:35 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-09-16 18:35:35 +0000

    media-gfx/kphotoalbum: Add missing USEdep on dev-qt/qtgui[jpeg]
    
    Bug: https://bugs.gentoo.org/870181
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/kphotoalbum/kphotoalbum-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 Larry the Git Cow gentoo-dev 2022-09-16 18:45:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f05d71585f0d63c9c67a6079d50f9dac74711042

commit f05d71585f0d63c9c67a6079d50f9dac74711042
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-09-16 18:35:35 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-09-16 18:45:39 +0000

    media-gfx/kphotoalbum: Add missing USEdep on dev-qt/qtgui[jpeg]
    
    Closes: https://bugs.gentoo.org/870181
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../{kphotoalbum-5.9.1.ebuild => kphotoalbum-5.9.1-r1.ebuild}           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)