Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 870115 - media-gfx/rawtherapee has gtkmm & librsvg in DEPEND only, but needed @ runtime
Summary: media-gfx/rawtherapee has gtkmm & librsvg in DEPEND only, but needed @ runtime
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Francesco Riosa
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-14 15:15 UTC by Ben Kohler
Modified: 2022-09-16 13:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2022-09-14 15:15:46 UTC
The deps on dev-cpp/gtkmm:3.0 and gnome-base/librsvg are in DEPEND only but the rawtherapee binary links to these, so they are required at runtime.  These should be moved to RDEPEND.  Thanks!
Comment 1 Ben Kohler gentoo-dev 2022-09-14 15:18:25 UTC
Something like this, and I'd be happy to commit this if you approve:

--- a/media-gfx/rawtherapee/rawtherapee-5.8-r1.ebuild
+++ b/media-gfx/rawtherapee/rawtherapee-5.8-r1.ebuild
@@ -19,10 +19,12 @@ RDEPEND="
        dev-cpp/atkmm:=
        dev-cpp/cairomm:=
        dev-cpp/glibmm:=
+       dev-cpp/gtkmm:3.0
        dev-cpp/pangomm:=
        dev-libs/expat
        dev-libs/glib:=
        dev-libs/libsigc++:2
+       gnome-base/librsvg
        media-libs/lcms:2
        media-libs/lensfun
        media-libs/libcanberra[gtk3]
@@ -34,9 +36,7 @@ RDEPEND="
        virtual/jpeg:0
        x11-libs/gtk+:3
        tcmalloc? ( dev-util/google-perftools )"
-DEPEND="${RDEPEND}
-       dev-cpp/gtkmm:3.0
-       gnome-base/librsvg"
+DEPEND="${RDEPEND}"
 BDEPEND="virtual/pkgconfig"

 S="${WORKDIR}/${MY_P}"
Comment 2 Larry the Git Cow gentoo-dev 2022-09-16 13:51:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04a1eea4936442187c7c7a892fe85bb55cf490a9

commit 04a1eea4936442187c7c7a892fe85bb55cf490a9
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2022-09-16 13:50:40 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2022-09-16 13:51:26 +0000

    media-gfx/rawtherapee: add libs to RDEPEND as well
    
    Closes: https://bugs.gentoo.org/870115
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 media-gfx/rawtherapee/rawtherapee-5.8-r1.ebuild | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)