Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869971 - net-im/dino-9999: depend on gui-libs/gtk:4, not gtk3
Summary: net-im/dino-9999: depend on gui-libs/gtk:4, not gtk3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-09-13 11:40 UTC by Enne Eziarc
Modified: 2023-03-21 08:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enne Eziarc 2022-09-13 11:40:15 UTC
Change happened upstream in July: https://github.com/dino/dino/commit/7e7dcedaf

It appears the gtk3 support is now gone entirely (and with it the deps on app-text/gspell)
Comment 1 Larry the Git Cow gentoo-dev 2023-03-11 16:26:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8aaa7074d5588eaf9ed6eebcd4820487879191f5

commit 8aaa7074d5588eaf9ed6eebcd4820487879191f5
Author:     Michael Vetter <jubalh@iodoru.org>
AuthorDate: 2023-02-24 10:06:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-11 16:24:02 +0000

    net-im/dino: add 0.4.0
    
    Bug: https://bugs.gentoo.org/851765
    Closes: https://bugs.gentoo.org/869971
    
    Signed-off-by: Michael Vetter <jubalh@iodoru.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-im/dino/Manifest          |  1 +
 net-im/dino/dino-0.4.0.ebuild | 93 +++++++++++++++++++++++++++++++++++++++++++
 net-im/dino/dino-9999.ebuild  | 15 +++----
 3 files changed, 102 insertions(+), 7 deletions(-)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-11 22:11:33 UTC
Should we have dropped the gspell dep too then?
Comment 3 Michael Vetter 2023-03-14 10:10:25 UTC
(In reply to Sam James from comment #2)
> Should we have dropped the gspell dep too then?

It's not quite clear to me. Since they still have the gspell cmake file there. But seems not to be used.
I asked in their MUC for clarification but didn't get a response.
I opened https://github.com/dino/dino/pull/1385 now. Once I got some feedback there I will update this bug.
Comment 4 Michael Vetter 2023-03-21 08:18:26 UTC
Did not get a verbal feedback from upstream yet. But they approved my PR on GitHub: https://github.com/dino/dino/pull/1385

So I created https://github.com/gentoo/gentoo/pull/30279 to remove the gspell dependency.