Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869785 - net-print/hplip-3.22.6 does not compile because of unspecified variable type
Summary: net-print/hplip-3.22.6 does not compile because of unspecified variable type
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2022-09-11 22:16 UTC by Jan Psota
Modified: 2022-09-15 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Psota 2022-09-11 22:16:58 UTC
Obvious solution:
--- a/prnt/hpps/pserror.c
+++ b/prnt/hpps/pserror.c
@@ -24,7 +24,7 @@ extern char *program ;	/* Defined by mai
 void message(int flags, char *format, ...)
 {
   va_list args ;
-  static column = 0 ;		/* current screen column for message wrap */
+  static int column = 0 ;	/* current screen column for message wrap */
   char msgbuf[MAX_MESSAGE] ;	/* buffer in which to put the message */
   char *bufptr = msgbuf ;	/* message buffer pointer */
 

proposed by Khem Raj <raj.khem@gmail.com>, found here:
https://cgit.openembedded.org/meta-openembedded/plain/meta-oe/recipes-extended/hplip/hplip/0003-pserror.c-Define-column-to-be-int-explcitly.patch
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-11 22:18:09 UTC
I assume this is with Clang 15.

In future, please do include the full build.log & emerge --info for completeness.
Comment 2 Jan Psota 2022-09-12 20:17:17 UTC
Yes, Clang-15. "New" ;-), C99 behaviour.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-15 18:58:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ffbc3953bf242a0fd241a0a2395a3d9616cd5b4

commit 6ffbc3953bf242a0fd241a0a2395a3d9616cd5b4
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2022-09-15 18:56:41 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2022-09-15 18:56:41 +0000

    net-print/hplip: Update patchset to fix build with Clang 15
    
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>
    
    Closes: https://bugs.gentoo.org/869785

 net-print/hplip/Manifest            | 1 +
 net-print/hplip/hplip-3.22.6.ebuild | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)