Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869755 - net-libs/nghttp2: consider enabling threads by default (IUSE="+threads")
Summary: net-libs/nghttp2: consider enabling threads by default (IUSE="+threads")
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 868336
  Show dependency tree
 
Reported: 2022-09-11 15:54 UTC by Holger Hoffstätte
Modified: 2022-09-14 11:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2022-09-11 15:54:57 UTC 
As per #868369 consider enabling thread support unconditionally and remove "threads" from IUSE.


Reproducible: Always
Comment 1 Bernard Cafarelli gentoo-dev 2022-09-14 11:33:28 UTC 
That sounds good, upstream default is threads enabled and documentation implies it is always enabled (threads features do not mention enabling configure flag). It seems flag is only there for MacOS X:
   Mac OS X users may need the ``--disable-threads`` configure option to
   disable multi-threading in nghttpd, nghttpx and h2load to prevent
   them from crashing. A patch is welcome to make multi threading work
   on Mac OS X platform.
Comment 2 Larry the Git Cow gentoo-dev 2022-09-14 11:51:49 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2de91bdd02292a37c134e69f005d751ede57f1f0

commit 2de91bdd02292a37c134e69f005d751ede57f1f0
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-09-11 16:17:48 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-09-14 11:51:22 +0000

    net-libs/nghttp2: enable threads by default
    
    Upstream enables pthreads by default, so enable it unconditionally.
    
    Closes: https://bugs.gentoo.org/869755
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/27211
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 net-libs/nghttp2/nghttp2-1.48.0.ebuild | 4 ++--
 net-libs/nghttp2/nghttp2-9999.ebuild   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)