Bug 869491 – media-gfx/iscan-3.65.0 passed test suite but did not execute any tests

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-09-10 11:57:59 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/iscan-3.65.0 passed test suite but did not execute any tests.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc

[Comment 1 Agostino Sarubbo 2022-09-10 11:58:02 UTC]

Created attachment 804457 [details]
build.log

build log and emerge --info

[Comment 2 Marcin Deranek 2022-09-10 14:38:13 UTC]

Why do you say so ?

$ grep ^PASS build.log 
PASS: scanner.utr
PASS: run-time.utr
PASS: octet.utr
PASS: log-no-check.utr
PASS: log-checking.utr
PASS: buffer.utr
PASS: null.utr
PASS: device.utr
PASS: memory.utr
PASS: descriptor.utr
PASS: stream.utr
PASS: string.utr
PASS: value.utr
PASS: file.utr
PASS: monitor.utr
PASS: quantity.utr
PASS: tiff.utr
PASS: option.utr
PASS: threshold.utr
PASS: pnm.utr
PASS: image-skip.utr
PASS: padding.utr
PASS: pdf.utr
PASS: shell-pipe.utr
PASS: magick.utr
PASS: jpeg.utr
PASS: reorient.utr
PASS: grammar-mechanics.utr
PASS: setter.utr
PASS: udev-rules.utr
PASS: grammar-formats.utr
PASS: grammar.utr
PASS: value.utr
PASS: main-failure.utr
PASS: command.utr
PASS: main.utr

[Comment 3 Agostino Sarubbo 2022-09-10 15:24:51 UTC]

(In reply to Marcin Deranek from comment #2)
> Why do you say so ?

The bug was a copy paste of a qa notice, that in this case is wrong. Sam already cc'ed matoro.

[Comment 4 Marcin Deranek 2022-09-10 16:40:34 UTC]

That's clear. Presumably #713186 can be closed taking into account this bug build.log which succeeds and iscan-3.61 not being in the tree anymore.

[Comment 5 matoro 2022-09-10 21:48:37 UTC]

Nope!  This warning is correct, the last test has an automagic dep on dev-util/uncrustify.

In configure.ac:
AC_CHECK_PROGS([UNCRUSTIFY], [uncrustify])
AM_CONDITIONAL([enable_uncrustify_test], [test x != "x$UNCRUSTIFY"])

And then in tests/Makefile.am:
check_PROGRAMS  =
if enable_uncrustify_test
check_PROGRAMS += indentation.utr
endif


Tested in a clean chroot, just installing dev-util/uncrustify makes the last test run and this QA warning go away with no changes to the ebuild.  Please add it as a test dep.

[Comment 6 Larry the Git Cow 2022-10-02 19:22:33 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26ee9a796e897030d195f58efba5e7250a642e29

commit 26ee9a796e897030d195f58efba5e7250a642e29
Author:     Marcin Deranek <[e-mail]>
AuthorDate: 2022-09-11 12:27:20 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2022-10-02 19:22:22 +0000

    media-gfx/iscan: Add missing dependency for tests
    
    Signed-off-by: Marcin Deranek <[e-mail]>
    Closes: https://bugs.gentoo.org/869491
    Closes: https://github.com/gentoo/gentoo/pull/27205
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 media-gfx/iscan/iscan-3.65.0.ebuild | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)