Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869290 - app-text/pdftk-3.3.2-r1 fails tests
Summary: app-text/pdftk-3.3.2-r1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-09 07:30 UTC by Agostino Sarubbo
Modified: 2022-09-10 17:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,75.22 KB, text/plain)
2022-09-09 07:30 UTC, Agostino Sarubbo
Details
Build log with tests passed (build.log,39.12 KB, text/plain)
2022-09-09 12:55 UTC, Volkmar W. Pogatzki
Details
Build log with tests passed (pdftk_log,73.68 KB, text/plain)
2022-09-09 13:00 UTC, Volkmar W. Pogatzki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-09 07:30:47 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-text/pdftk-3.3.2-r1 fails tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-09 07:30:49 UTC
CC'ing also the author of the commit (d88c28b7816a02cbbac3d37393c53b885245cc60)
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-09 07:30:50 UTC
Created attachment 804085 [details]
build.log

build log and emerge --info
Comment 3 Volkmar W. Pogatzki 2022-09-09 12:55:45 UTC
Created attachment 804112 [details]
Build log with tests passed

Cannot reproduce.  
Here, it simply continues ( einfo "Running second test" ).
Attaching my build log.

In the ebuild the tests are grouped in two test runs because some tests, all in the first group, seem not to produce any "failed" or "OK" output.
Comment 4 Volkmar W. Pogatzki 2022-09-09 13:00:08 UTC
Created attachment 804115 [details]
Build log with tests passed

Attaching the correct log.
Comment 5 Florian Schmaus gentoo-dev 2022-09-10 16:35:36 UTC
FWIW, I can reproduce this is an clean container (using ebuildtester). The test also continue to fail if I emerge pdftk with FEATURES="-test", and then re-emerge with tests enabled. But on my desktop the tests succeed. Emerging with --debug shows

+ java -cp target/test-classes:pdftk.jar:/usr/share/junit-4/lib/junit.jar:/usr/share/system-rules/lib/system-rules.jar:/usr/share/hamcrest-core-1.3/lib/hamcrest-core.jar:/usr/share/bcprov/lib/bcprov.jar:/usr/share/commons-lang-3.6/lib/commons-lang.jar:/usr/share/junit-4/lib/junit.ja
r:/usr/share/bcprov/lib/bcprov.jar:/usr/share/commons-lang-3.6/lib/commons-lang.jar:/usr/share/hamcrest-core-1.3/lib/hamcrest-core.jar -Djava.io.tmpdir=/var/tmp/portage/app-text/pdftk-3.3.2-r1/temp -Djava.awt.headless=true org.junit.runner.JUnitCore com.gitlab.pdftk_java.CatTest com.gitlab.pdftk_java.DataTest com.gitlab.pdftk_java.FormTest com.gitlab.pdftk_java.MultipleTest
JUnit version 4.13.2-SNAPSHOT
[…]
WARNING: The creator of the input PDF:
   test/files/issue88.pdf
   has set an owner password (which is not required to handle this PDF).
   You did not supply this password. Please respect any copyright.
+ die 'Running junit failed'

and on my desktop

+ java -cp target/test-classes:pdftk.jar:/usr/share/junit-4/lib/junit.jar:/usr/share/system-rules/lib/system-rules.jar:/usr/share/hamcrest-core-1.3/lib/hamcrest-core.jar:/usr/share/bcprov/lib/bcprov.jar:/usr/share/commons-lang-3.6/lib/commons-lang.jar:/usr/share/junit-4/lib/junit.jar:/usr/share/bcprov/lib/bcprov.jar:/usr/share/commons-lang-3.6/lib/commons-lang.jar:/usr/share/hamcrest-core-1.3/lib/hamcrest-core.jar -Djava.io.tmpdir=/data-scratch/var-tmp/portage/app-text/pdftk-3.3.2-r1/temp -Djava.awt.headless=true org.junit.runner.JUnitCore com.gitlab.pdftk_java.CatTest com.gitlab.pdftk_java.DataTest com.gitlab.pdftk_java.FormTest com.gitlab.pdftk_java.MultipleTest
JUnit version 4.13.2-SNAPSHOT
[…]
WARNING: The creator of the input PDF:
   test/files/issue88.pdf
   has set an owner password (which is not required to handle this PDF).
   You did not supply this password. Please respect any copyright.
+ einfo 'Running second test'

besides the different tmpdir, there appears to difference in the java invocations to run junit.

I believe the issue88.pdf, which seems to be pdftk's FormTest.generate_fdf_issue88() unit test, could be a false flag and the culprit somewhere else.

I think the next step should be to get junit talking. That is, increase its verbosity. Because right now, it appears to be not producing any logs (at least, I couldn't find one).
Comment 6 Larry the Git Cow gentoo-dev 2022-09-10 17:30:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=75a9b54214a02b4168f48b04693a51f61f6d01f2

commit 75a9b54214a02b4168f48b04693a51f61f6d01f2
Author:     Florian Schmaus <flow@gentoo.org>
AuthorDate: 2022-09-10 17:29:14 +0000
Commit:     Florian Schmaus <flow@gentoo.org>
CommitDate: 2022-09-10 17:29:34 +0000

    app-text/pdftk: add missing poppler[cairo] test dep
    
    Closes: https://bugs.gentoo.org/869290
    Signed-off-by: Florian Schmaus <flow@gentoo.org>

 app-text/pdftk/pdftk-3.3.2-r1.ebuild | 1 +
 1 file changed, 1 insertion(+)