Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868711 - dev-python/astor-0.8.1-r1 fails tests
Summary: dev-python/astor-0.8.1-r1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2022-09-06 10:30 UTC by Agostino Sarubbo
Modified: 2023-02-09 01:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,79.29 KB, text/plain)
2022-09-06 10:30 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-06 10:30:31 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/astor-0.8.1-r1 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-06 10:30:34 UTC
Created attachment 803395 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-06 10:30:36 UTC
Error(s) that match a know pattern:


        except OverflowError:
E       ValueError: Exceeds the limit (4300) for integer string conversion
FAILED tests/test_code_gen.py::CodegenTestCase::test_huge_int - ValueError: E...
Comment 3 Paolo Pedroni 2022-10-03 09:53:28 UTC
I don't think this has anything to do with lto, but it's due to the new handling of big int in python.
Comment 4 Jonathan Lovelace 2023-02-09 00:51:28 UTC
I see this same failure when rebuilding due to the masking of the python_targets_python3_8 flag, and my system does not have LTO enabled.
Comment 5 Larry the Git Cow gentoo-dev 2023-02-09 00:57:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=682e928678ce1fd48d8a4330d70875bc8c37ace6

commit 682e928678ce1fd48d8a4330d70875bc8c37ace6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-09 00:56:24 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-09 00:57:18 +0000

    dev-python/astor: fix tests w/ newer Pythons (bigint handling)
    
    Closes: https://bugs.gentoo.org/868711
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/astor/astor-0.8.1-r1.ebuild             |  4 ++++
 .../astor/files/astor-0.8.1-tests-bigint.patch     | 23 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)