Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868648 - app-arch/pigz: create alternative to USE=symlink to overtake app-arch/gzip
Summary: app-arch/pigz: create alternative to USE=symlink to overtake app-arch/gzip
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 886017
Blocks:
  Show dependency tree
 
Reported: 2022-09-06 01:40 UTC by Sam James
Modified: 2022-12-27 11:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-06 01:40:33 UTC
USE=symlink doesn't work for merged-usr (see bug 868312).

I quite like being able to transparently use pigz and modifying just tar via EXTRA_ECONF doesn't cover other uses.

Perhaps we should go for a awk-like situation with an 'eselect gzip'? This feels like the only practical way of moving forward with overriding the binary, and it's also the convention for handling situations like this already.
Comment 1 Mike Gilbert gentoo-dev 2022-09-06 01:47:12 UTC
I really question if this is worth the effort of creating an eselect-controlled symlink and moving everything around. For people who want the override, they could add a symlink or shell script in /usr/local/bin.
Comment 2 Larry the Git Cow gentoo-dev 2022-09-06 03:37:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43807853b0b9335a2c51a7b92820f9ee2091dcff

commit 43807853b0b9335a2c51a7b92820f9ee2091dcff
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-09-06 03:36:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-06 03:36:46 +0000

    profiles/base: mask app-arch/lbzip2[symlink], app-arch/pigz[symlink]
    
    Incompatible with merged-usr and is a fundamentally flaky approach.
    - app-arch/lbzip2: bug #868318 (possible solution in bug #868651)
    - app-arch/pigz: bug #868312 (possible solution in bug #868648)
    
    It's suggested that users who want this feature use a wrapper
    script in /usr/local (or otherwise on PATH), or configure tools
    like tar to use lbzip2 & pigz respectively using EXTRA_ECONF.
    
    Bug: https://bugs.gentoo.org/868318
    Bug: https://bugs.gentoo.org/868312
    Bug: https://bugs.gentoo.org/868651
    Bug: https://bugs.gentoo.org/868648
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/base/package.use.mask | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 3 Georgy Yakovlev archtester gentoo-dev 2022-09-13 23:36:53 UTC
/usr/local/bin override does not work with portage if I recall correctly, as something mangles the path order and re-orders local later in order.

it works for some invocations, but not for others.
it was long time ago last time I looked at it, but since profiles happened I guess it's time to think on it again.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-01 01:41:12 UTC
Done for bzip2 at https://bugs.gentoo.org/868651#c7.
Comment 5 Larry the Git Cow gentoo-dev 2022-12-01 19:38:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7dbd9efce69d73d24db421189e4d2beccbcd6da2

commit 7dbd9efce69d73d24db421189e4d2beccbcd6da2
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-12-01 16:11:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-01 19:38:23 +0000

    app-alternatives/gzip: Add a package for gzip symlinks
    
    Closes: https://bugs.gentoo.org/868648
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-alternatives/gzip/gzip-0.ebuild | 45 +++++++++++++++++++++++++++++++++++++
 app-alternatives/gzip/metadata.xml  | 20 +++++++++++++++++
 2 files changed, 65 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2022-12-27 11:59:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=30f64050da3809c7bea17cce2fc5d01f0f125cdd

commit 30f64050da3809c7bea17cce2fc5d01f0f125cdd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-27 11:56:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-27 11:56:29 +0000

    app-arch/pigz: drop masked USE=symlink
    
    Use app-alternative/gzip instead (see news item).
    
    Bug: https://bugs.gentoo.org/868312
    Bug: https://bugs.gentoo.org/868648
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/pigz/pigz-2.7.ebuild | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)