Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868549 - dev-php/PHPMailer-6.5.1 fails to compile (lto): PHP Parse error: syntax error, unexpected token "readonly" in AnnotationDriver.php on line 173
Summary: dev-php/PHPMailer-6.5.1 fails to compile (lto): PHP Parse error: syntax error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-05 06:59 UTC by Agostino Sarubbo
Modified: 2022-09-06 14:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,46.99 KB, text/plain)
2022-09-05 06:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-05 06:59:53 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-php/PHPMailer-6.5.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-05 06:59:56 UTC
Created attachment 803272 [details]
build.log

build log and emerge --info
Comment 2 Michael Orlitzky gentoo-dev 2022-09-06 11:49:47 UTC
This probably needs phpDocumentor-3.x, but I'm just going to drop USE=doc given what a nightmare phpDocumentor has been in the past.
Comment 3 Larry the Git Cow gentoo-dev 2022-09-06 14:40:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a53636f18433712c81b056789aa92fa251a4151

commit 8a53636f18433712c81b056789aa92fa251a4151
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2022-09-06 14:14:49 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-09-06 14:14:56 +0000

    dev-php/PHPMailer: add 6.6.4, drop 6.5.1
    
    This new version uses EAPI=8 and drops USE=doc. It looks like building
    the API documentation requires a new version of dev-php/phpDocumentor,
    and that package has been a headache for many years.
    
    Closes: https://bugs.gentoo.org/868549
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 dev-php/PHPMailer/Manifest                         |  2 +-
 ...PMailer-6.5.1.ebuild => PHPMailer-6.6.4.ebuild} | 29 +++-------------------
 2 files changed, 4 insertions(+), 27 deletions(-)