Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868360 - media-gfx/graphicsmagick: enable threads by default (IUSE="threads")
Summary: media-gfx/graphicsmagick: enable threads by default (IUSE="threads")
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Codec Project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 868336
  Show dependency tree
 
Reported: 2022-09-04 07:28 UTC by Holger Hoffstätte
Modified: 2022-09-10 11:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2022-09-04 07:28:25 UTC
Graphicsmagick has both ISUE="threads" and "openmp".
This makes no sense, since:
1) gm-as-library should be threadsafe by default
2) gm using multiple cores for work uses openmp, which in turn uses pthreads under the hood, so -threads makes no sense either

Enable threading support by default and leave scalability to openmp.
This will mimick ImageMagick, which also enables threads by default.


Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2022-09-10 11:18:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2be0cf2f7a25081ed26081f5822c3843b3ae31a

commit d2be0cf2f7a25081ed26081f5822c3843b3ae31a
Author:     Holger Hoffstätte <holger@applied-asynchrony.com>
AuthorDate: 2022-09-04 12:10:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-10 11:17:49 +0000

    media-gfx/graphicsmagick: enable threads by default
    
    This follows upstream's default behaviour and mimicks ImageMagick.
    
    Closes: https://bugs.gentoo.org/868360
    Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
    Closes: https://github.com/gentoo/gentoo/pull/27136
    Signed-off-by: Sam James <sam@gentoo.org>

 .../graphicsmagick/graphicsmagick-1.3.38-r3.ebuild | 161 +++++++++++++++++++++
 .../graphicsmagick/graphicsmagick-9999.ebuild      |   4 +-
 2 files changed, 163 insertions(+), 2 deletions(-)