Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868249 - net-wireless/gnuradio: missing runtime dependency on dev-libs/spdlog
Summary: net-wireless/gnuradio: missing runtime dependency on dev-libs/spdlog
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Radio project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-03 09:40 UTC by JohnLM
Modified: 2022-09-06 17:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JohnLM 2022-09-03 09:40:50 UTC
gnuradio does depend on dev-libs/spdlog, but as build-time dependency while it should be a runtime dependency.

`emerge --declean --with-bdeps=n` happily removed dev-libs/spdlog after which it immediately printed:

```
!!! existing preserved libs:
>>> package: dev-libs/spdlog-1.9.2
 *  - /usr/lib64/libspdlog.so.1
 *  - /usr/lib64/libspdlog.so.1.9.2
 *      used by /usr/lib/python3.10/site-packages/gnuradio/gr/gr_python.cpython-310-x86_64-linux-gnu.so (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-analog.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-audio.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-blocks.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-digital.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-fft.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-filter.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-network.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-pdu.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-qtgui.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
 *      used by /usr/lib64/libgnuradio-runtime.so.3.10.3.0 (net-wireless/gnuradio-3.10.3.0-r1)
```

Reproducible: Always

Steps to Reproduce:
1. emerge net-wireless/gnuradio
2. unemerge dev-libs/spdlog with `emerge --depclean --with-bdeps=n dev-libs/spdlog`
Comment 1 Thomas Beierlein gentoo-dev 2022-09-06 05:41:37 UTC
Thanks for pointing it out. Will be fixed shortly.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-06 05:43:22 UTC
I suspect this is what zerochaos hit with:
```
commit c2c5a989cd56645605d39a132eb1b3817227ebbf
Author: Rick Farina <zerochaos@gentoo.org>
Date:   Sun Sep 4 17:26:32 2022 -0400

    net-wireless/gr-ieee802154: minor cleanup

    remove stray pyc/pyo files
    Add missing dep
    This really should have been fine imho since gnuradio requires it, but it
    managed to fail to build for me due to dev-libs/spdlog missing somehow.

    Signed-off-by: Rick Farina <zerochaos@gentoo.org>
```

but he didn't look into it sufficiently.
Comment 3 Thomas Beierlein gentoo-dev 2022-09-06 16:56:39 UTC
(In reply to Sam James from comment #2)
> I suspect this is what zerochaos hit with:
> ```
> commit c2c5a989cd56645605d39a132eb1b3817227ebbf
> Author: Rick Farina <zerochaos@gentoo.org>
> Date:   Sun Sep 4 17:26:32 2022 -0400
> 
>     net-wireless/gr-ieee802154: minor cleanup
> 
>     remove stray pyc/pyo files
>     Add missing dep
>     This really should have been fine imho since gnuradio requires it, but it
>     managed to fail to build for me due to dev-libs/spdlog missing somehow.
> 
>     Signed-off-by: Rick Farina <zerochaos@gentoo.org>
> ```
> 
> but he didn't look into it sufficiently.

No, that was another problem. pyc/pyo files are generated by pybind11 while build in gnuradio-3.10 environment.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-06 16:57:29 UTC
Right, but the "add missing dep" and spdlog reference..?
Comment 5 Larry the Git Cow gentoo-dev 2022-09-06 16:59:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c7a601c248920ff87566ef3b614dd925a572a8f

commit 3c7a601c248920ff87566ef3b614dd925a572a8f
Author:     Thomas Beierlein <tomjbe@gentoo.org>
AuthorDate: 2022-09-06 16:58:24 +0000
Commit:     Thomas Beierlein <tomjbe@gentoo.org>
CommitDate: 2022-09-06 16:58:24 +0000

    net-wireless/gnuradio: Move dev-libs/spdlog to RDEPEND
    
    Closes: https://bugs.gentoo.org/868249
    Signed-off-by: Thomas Beierlein <tomjbe@gentoo.org>

 net-wireless/gnuradio/gnuradio-3.10.3.0-r2.ebuild | 246 ++++++++++++++++++++++
 1 file changed, 246 insertions(+)
Comment 6 Thomas Beierlein gentoo-dev 2022-09-06 17:00:03 UTC
(In reply to Sam James from comment #4)
> Right, but the "add missing dep" and spdlog reference..?

You are right. I did not read to the end. Sorry.