Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 867856 - media-gfx/gimp-2.99.12 fails tests
Summary: media-gfx/gimp-2.99.12 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords: PullRequest
: 790791 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-01 09:44 UTC by Paolo Pedroni
Modified: 2023-07-15 21:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gimp-2.99.12:20220901-082335.log.gz (gimp-2.99.12:20220901-082335.log.gz,170.99 KB, application/gzip)
2022-09-01 09:44 UTC, Paolo Pedroni
Details
testlog.txt (testlog.txt,34.05 KB, text/plain)
2022-09-01 09:45 UTC, Paolo Pedroni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2022-09-01 09:44:36 UTC
Created attachment 802411 [details]
gimp-2.99.12:20220901-082335.log.gz

Summary of Failures:

 6/10 gimp:app / core                                    FAIL            1.41s   (exit status 133 or signal 5 SIGTRAP)
 7/10 gimp:app / xcf                                     FAIL            1.45s   (exit status 133 or signal 5 SIGTRAP)
 8/10 gimp:app / ui                                      FAIL            1.92s   (exit status 133 or signal 5 SIGTRAP)
 9/10 gimp:app / save-and-export                         FAIL            1.94s   (exit status 133 or signal 5 SIGTRAP)
10/10 gimp:app / single-window-mode                      FAIL            1.97s   (exit status 133 or signal 5 SIGTRAP)


Ok:                 3   
Expected Fail:      0   
Fail:               5   
Unexpected Pass:    0   
Skipped:            2   
Timeout:            0   

Full log written to /var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/meson-logs/testlog.txt
 * ERROR: media-gfx/gimp-2.99.12::gentoo failed (test phase):
 *   tests failed

All failures in tests have the following:
Could not execute plug-in "goat-exercise-vala"
(/usr/lib64/gimp/2.99/extensions/org.gimp.extension.goat-exercises/goat-exercise-vala)
because it uses an obsolete version of the plug-in protocol.

(/var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/app/tests/save-and-export:304): LibGimpBase-WARNING **: 10:25:54.698: /var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/app/tests/save-and-export: gimp_wire_read(): error

as if tests use the currently installed files instead of the just compiled ones.

# emerge --info =media-gfx/gimp-2.99.12
Portage 3.0.35 (python 3.10.6-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-11.3.0, glibc-2.35-r8, 5.18.19-gentoo-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.18.19-gentoo-r1-x86_64-AMD_Ryzen_7_5700G_with_Radeon_Graphics-with-glibc2.35
KiB Mem:    65121060 total,   1150668 free
KiB Swap:   67108860 total,  67000060 free
Timestamp of repository gentoo: Thu, 01 Sep 2022 06:45:01 +0000
Head commit of repository gentoo: 0490be31096593a1e9734b7f07a37364a87784a3
sh dash 0.5.11.5
ld GNU ld (Gentoo 2.38 p4) 2.38
distcc 3.4 x86_64-pc-linux-gnu [disabled]
ccache version 4.5.1 [disabled]
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r1::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.34.1-r3::gentoo
dev-lang/python:           3.10.6_p2::gentoo
dev-lang/rust:             1.62.1::gentoo
dev-util/ccache:           4.5.1::gentoo
dev-util/cmake:            3.23.3::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          251.2::gentoo
sys-devel/autoconf:        2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.6::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r8::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.europe.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
AR="/usr/bin/gcc-ar"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver3 -ftree-vectorize -flto=16"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver3 -ftree-vectorize -flto=16"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going y --with-bdeps y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver3 -ftree-vectorize -flto=16"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live cgroup compress-build-logs config-protect-if-modified distlocks ebuild-locks ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms sign split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -frecord-gcc-switches -march=znver3 -ftree-vectorize -flto=16"
GENTOO_MIRRORS="http://tux.rainside.sk/gentoo/ https://mirror.init7.net/gentoo/ http://mirror.leaseweb.com/gentoo/ http://mirror.netcologne.de/gentoo/"
LANG="it_IT.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -ftree-vectorize -flto=16"
LINGUAS="it it_IT"
MAKEOPTS="-j16 -l16"
NM="/usr/bin/gcc-nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="/usr/bin/gcc-ranlib"
SHELL="/bin/bash"
USE="X a52 aac aalib acl acpi activities adns alsa amd64 ao audiofile bash-completion bluetooth branding brotli bzip2 cairo caps cdda cddb cdparanoia cdr cli crypt css cups curl dbus declarative dga djvu dri dts dvd dvdr encode exif expat fbcon ffmpeg fftw flac fontconfig foomaticdb fortran ftp gd gdbm geoip gif gimp gmp gnutls gphoto2 gpm graphviz gtk gui guile handbook iconv icu idn imagemagick imlib introspection ipv6 java javascript jbig jemalloc jpeg jpeg2k kde kwallet lame lcms libass libglvnd libnotify libsamplerate libtirpc lm-sensors lua lz4 lzma lzo mad magic mmap mng mp3 mp4 mpeg mplayer multilib musicbrainz ncurses nls nptl offensive ogg openal opengl openmp pam pango pcre pdf plasma png policykit postscript ppds pulseaudio qml qt5 rdesktop readline recode samba sctp sdl seccomp sndfile sockets speex spell split-usr sqlite ssl startup-notification svg symlink syslog systemd sysvipc taglib telemetry test theora threads tidy tiff truetype udev udisks unicode upower usb v4l vaapi vala verify-sig vim-syntax vnc vorbis wavpack wayland webp widgets win32codecs wmf wxwidgets x264 xattr xcb xine xinerama xml xpm xscreensaver xv xvid yahoo zip zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2020" ALSA_CARDS="hda-intel virmidi" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" CURL_SSL="gnutls" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="it en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeon radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS

# emerge -1pqv =media-gfx/gimp-2.99.12
[ebuild     U ] media-gfx/gimp-2.99.12 [2.99.10-r1] USE="X%* aalib alsa heif jpeg2k jpegxl lua mng postscript test udev vala vector-icons webp wmf xpm -doc -gnome -javascript -openexr -python -unwind (-aqua%)" CPU_FLAGS_X86="(-mmx%*) (-sse%*)" LUA_SINGLE_TARGET="luajit" PYTHON_SINGLE_TARGET="python3_10 -python3_8 -python3_9 -python3_11%"
Comment 1 Paolo Pedroni 2022-09-01 09:45:04 UTC
Created attachment 802414 [details]
testlog.txt
Comment 2 Sergey Torokhov 2022-09-05 08:09:31 UTC
(In reply to Paolo Pedroni from comment #0)
> Created attachment 802411 [details]
> gimp-2.99.12:20220901-082335.log.gz
> 
> Summary of Failures:
> 
>  6/10 gimp:app / core                                    FAIL           
> 1.41s   (exit status 133 or signal 5 SIGTRAP)
>  7/10 gimp:app / xcf                                     FAIL           
> 1.45s   (exit status 133 or signal 5 SIGTRAP)
>  8/10 gimp:app / ui                                      FAIL           
> 1.92s   (exit status 133 or signal 5 SIGTRAP)
>  9/10 gimp:app / save-and-export                         FAIL           
> 1.94s   (exit status 133 or signal 5 SIGTRAP)
> 10/10 gimp:app / single-window-mode                      FAIL           
> 1.97s   (exit status 133 or signal 5 SIGTRAP)
> 
> 
> Ok:                 3   
> Expected Fail:      0   
> Fail:               5   
> Unexpected Pass:    0   
> Skipped:            2   
> Timeout:            0   
> 
> Full log written to
> /var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/meson-logs/
> testlog.txt
>  * ERROR: media-gfx/gimp-2.99.12::gentoo failed (test phase):
>  *   tests failed
> 
> All failures in tests have the following:
> Could not execute plug-in "goat-exercise-vala"
> (/usr/lib64/gimp/2.99/extensions/org.gimp.extension.goat-exercises/goat-
> exercise-vala)
> because it uses an obsolete version of the plug-in protocol.
> 
> (/var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/app/tests/
> save-and-export:304): LibGimpBase-WARNING **: 10:25:54.698:
> /var/tmp/portage/media-gfx/gimp-2.99.12/work/gimp-2.99.12-build/app/tests/
> save-and-export: gimp_wire_read(): error
> 
> as if tests use the currently installed files instead of the just compiled
> ones.
> 

Well, there are the 'good' news: I now could reproduce it.

I did several tests with applying of similar CFLAGS and CXXFLAGS as I initially assumed this and other (https://bugs.gentoo.org/790791) issue is related specific optimization options. I even think it's related to LTO feature. Sorry, I really didn't ignored these issues - I just had no success to reproduce them.

And finally I saw that I initially missed (and what you are initially mentioned) - the current and previous merge were with FEATURES="test" enabled :( Enabling USE="test" is insufficient to reproduced as test phase will be skipped. I.e. to reproduce issue the following are require:

1. FEATURES="test" emerge =gimp-2.99.10-r1
2. FEATURES="test" emerge =gimp-2.99.12

The list of installed files of gimp-2.99.10-r1 is identical for FEATURES="test" is enabled or not. Therefore it seems something could be differ within files. But I currently don't have idea how to workaround it. I need make additional investigation to check installed files.

But the easiest way is disable FEATURES="test". It's specific FEATURES that usually is not required to be globally enabled by user. I use it only for packaging purpose and system doesn't has it enabled.
Comment 3 Sergey Torokhov 2022-09-05 08:41:53 UTC
*** Bug 790791 has been marked as a duplicate of this bug. ***
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-06 05:58:45 UTC
(In reply to Sergey Torokhov from comment #2)
> But the easiest way is disable FEATURES="test". It's specific FEATURES that
> usually is not required to be globally enabled by user. I use it only for
> packaging purpose and system doesn't has it enabled.

He deliberately runs it to find problems, but I think it's worth saying if you don't recognise someone's name, in case they don't realise, indeed, FWIW.
Comment 5 Sergey Torokhov 2022-09-06 10:06:23 UTC
I suspect the issue is related to gimp pkgconfig: on test phase it prefers system installed instead of one from sandbox and then linked libgimp etc that have too old API for newly run of tests. 

On the other hand the test errors occur only if previous version of gimp-2.99.x was merged with FEATURES="test"

But today I have a problem with fail tests media-gfx/gimp-2.99.10-r1 due to some other reason (without gimp installed) while yesterday it was OK :(
Comment 6 Sergey Torokhov 2022-12-22 00:39:31 UTC
I wasn't able to reproduce this issue with update of gimp-2.99.12 to gimp-2.99.14 likely because there was no libgimp.so api update this time.

The gimp-2.99.10 was removed due to new heif version incompatibility.
Comment 7 Sergey Torokhov 2023-06-28 20:35:37 UTC
(In reply to Sergey Torokhov from comment #6)
> I wasn't able to reproduce this issue with update of gimp-2.99.12 to
> gimp-2.99.14 likely because there was no libgimp.so api update this time.
> 
> The gimp-2.99.10 was removed due to new heif version incompatibility.

And now gimp-9999 has similar test failures again if gimp-2.99.14 is installed in the system :(
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-06-28 20:53:48 UTC
(In reply to Sergey Torokhov from comment #7)
> (In reply to Sergey Torokhov from comment #6)
> > I wasn't able to reproduce this issue with update of gimp-2.99.12 to
> > gimp-2.99.14 likely because there was no libgimp.so api update this time.
> > 
> > The gimp-2.99.10 was removed due to new heif version incompatibility.
> 
> And now gimp-9999 has similar test failures again if gimp-2.99.14 is
> installed in the system :(

Do we know how it's detecting it? Is it PKG_CONFIG_PATH, or is it (more likely, perhaps) PATH or LD_LIBRARY_PATH which we should set?
Comment 9 Sergey Torokhov 2023-06-30 21:31:04 UTC
(In reply to Sam James from comment #8)

> Do we know how it's detecting it? Is it PKG_CONFIG_PATH, or is it (more
> likely, perhaps) PATH or LD_LIBRARY_PATH which we should set?

The setting up the meson arg '--pkg-config-path' and/or '--build.pkg-config-path' has no results.

You are right! 
The passing 'local -x LD_LIBRARY_PATH="${BUILD_DIR}/libgimp:${LD_LIBRARY_PATH}"' into 'src_test()' seems fix the problem (if any test doesn't fail due to timeout). I check it again and then file a PR.
Comment 10 Larry the Git Cow gentoo-dev 2023-07-13 08:25:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d7aad12bcff9ee2bc6da480847d8415b83415401

commit d7aad12bcff9ee2bc6da480847d8415b83415401
Author:     Sergey Torokhov <torokhov-s-a@yandex.ru>
AuthorDate: 2023-06-30 21:34:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-07-13 08:25:21 +0000

    media-gfx/gimp: 9999.ebuild. Pass LD_LIBRARY_PATH for src_test() phase.
    
    While running the tests the gimp:2.99 tries to link system
    libgimp-3.0.so if gimp:2.99 is already installed.
    If system libgimp-3.0 has old GIMP API then it causes some tests fail.
    The proposed changes should fix this problem.
    
    Closes: https://bugs.gentoo.org/867856
    Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru>
    Closes: https://github.com/gentoo/gentoo/pull/31683
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/gimp/gimp-9999.ebuild | 5 +++++
 1 file changed, 5 insertions(+)
Comment 11 Sergey Torokhov 2023-07-15 21:08:38 UTC
(In reply to Sergey Torokhov from comment #9)
> (In reply to Sam James from comment #8)
> 
> > Do we know how it's detecting it? Is it PKG_CONFIG_PATH, or is it (more
> > likely, perhaps) PATH or LD_LIBRARY_PATH which we should set?
> 
> The setting up the meson arg '--pkg-config-path' and/or
> '--build.pkg-config-path' has no results.
> 
> You are right! 
> The passing 'local -x
> LD_LIBRARY_PATH="${BUILD_DIR}/libgimp:${LD_LIBRARY_PATH}"' into 'src_test()'
> seems fix the problem (if any test doesn't fail due to timeout). I check it
> again and then file a PR.

It seems the issue is related to meson: https://github.com/mesonbuild/meson/issues/2881

The LD_LIBRARY_PATH passing partially fixes issue but I still has failed "gimp-core" test due to timeout while on 2nd try it passed. Currently I just make gimp-2.99.16 bump without additional changes in https://github.com/gentoo/gentoo/pull/31903