https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-libs/softhsm-2.6.1-r2 fails tests (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 802093 [details] build.log build log and emerge --info
Created attachment 802096 [details] 1-test-suite.log 1-test-suite.log
reproduced on non-lto too
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cbb9e3501494ab725ed8b5f90d4edaa14fea2d1f commit cbb9e3501494ab725ed8b5f90d4edaa14fea2d1f Author: Sam James <sam@gentoo.org> AuthorDate: 2024-04-15 07:56:04 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-15 08:01:25 +0000 dev-libs/softhsm: EAPI 8, pull in various correctness fixes from Fedora * EAPI 8 * Pull in various memory safety & OpenSSL 3 fixes from Fedora (upstream is inactive) * Filter LTO which also causes tests to fail in addition to the above Closes: https://bugs.gentoo.org/867637 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/softhsm/Manifest | 1 + dev-libs/softhsm/softhsm-2.6.1-r3.ebuild | 61 ++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+)
(I suspect there were/are several failures, some with and some without LTO.)