https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: dev-libs/mathjax-2.7.7 installs files with broken symlink. Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 801898 [details] build.log build log and emerge --info
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61a07b398daf65f210933fef08d7697bab56c97e commit 61a07b398daf65f210933fef08d7697bab56c97e Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-02-14 23:46:25 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-15 13:50:27 +0000 dev-libs/mathjax: include USE=docs as part of the package (3.x) Do not use a separated app-docs/mathjax-docs. It is impossible to get correct: the symlink is generated using best_version, which applies at build time but doesn't match the version at runtime, so having an -r1 breaks the package. It also wasn't implemented correctly even if it could be gotten correct, because the docs package is a build time dependency, not a runtime one. To cap it off, this was introduced as a side effect of updating the package to 3.x, in an attempt to solve the broken symlink in the 2.x package. But it never referenced bug 867370 in the commit message. While we are at it, fix a flaw in the code merged from mathjax-docs, which didn't implement python_check_deps. Fixes: 46560543c9d48506feb83de473a7b0bd0298ae83 Bug: https://bugs.gentoo.org/837722 Closes: https://bugs.gentoo.org/867370 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/mathjax/Manifest | 1 + dev-libs/mathjax/mathjax-3.2.2-r2.ebuild | 53 +++++++++++++++++++++++--------- 2 files changed, 39 insertions(+), 15 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8e93a9fe1a6a2c04b98590e3526df07018111e8 commit d8e93a9fe1a6a2c04b98590e3526df07018111e8 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-02-14 23:46:25 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-15 13:50:25 +0000 dev-libs/mathjax: include USE=docs as part of the package (2.x) Do not use a separated app-docs/mathjax-docs. It is impossible to get correct: the symlink is generated using ${SLOT}, which is totally bogus as the docs package uses ${PF} and is unknowable. The symlink was very broken. In bug 526128, it was stated that there are 2 options for handling docs as part of a separate tarball: - remove doc support (and optionally create a separate package) - make doc support depend on a separate package It's baffling that the final option of just... having two SRC_URI files and installing the docs... was totally overlooked. Fixes: c6e861e430f795dd862fe05fed3f93ef2ca298a9 Bug: https://bugs.gentoo.org/526128 Bug: https://bugs.gentoo.org/867370 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-libs/mathjax/Manifest | 1 + dev-libs/mathjax/mathjax-2.7.7-r1.ebuild | 92 ++++++++++++++++++++++++++++++++ 2 files changed, 93 insertions(+)
