Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 866896 - net-libs/webkit-gtk-2.36.7 fails to compile (lto): [-Werror=odr]
Summary: net-libs/webkit-gtk-2.36.7 fails to compile (lto): [-Werror=odr]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-27 07:10 UTC by Kostadin Shishmanov
Modified: 2024-01-05 12:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log compressed with xz (build.log.xz,143.09 KB, application/x-xz)
2022-08-27 07:10 UTC, Kostadin Shishmanov 		Details
emerge --info (emerge-info.txt,7.07 KB, text/plain)
2022-08-27 07:10 UTC, Kostadin Shishmanov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kostadin Shishmanov 2022-08-27 07:10:10 UTC 
Created attachment 801328 [details]
build.log compressed with xz

net-libs/webkit-gtk-2.36.7 fails to compile with CFLAGS=-flto=auto -Werror=lto-type-mismatch -Werror=odr -Werror=strict-aliasing
Comment 1 Kostadin Shishmanov 2022-08-27 07:10:47 UTC 
Created attachment 801331 [details]
emerge --info
Comment 2 Matt Turner gentoo-dev 2022-08-31 19:29:25 UTC 
The webkit-gtk project uses -Wno-odr intentionally:

> -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-odr
> -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-odr - Success

so building with -Werror=odr is not going to work.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-19 15:42:39 UTC 
(In reply to Matt Turner from comment #2)
> The webkit-gtk project uses -Wno-odr intentionally:
> 
> > -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-odr
> > -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-odr - Success
> 
> so building with -Werror=odr is not going to work.

Then webkit-gtk should be filtering LTO as it's clearly unsafe.
Comment 4 Larry the Git Cow gentoo-dev 2024-01-05 12:37:03 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21109fa861f07a6ae06cfbed1ef2c721bfae9afd

commit 21109fa861f07a6ae06cfbed1ef2c721bfae9afd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-01-05 12:35:53 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-05 12:35:53 +0000

    net-libs/webkit-gtk: filter LTO
    
    ODR violations thanks to Bison. Fortunately, upstream are open to fixing it,
    it just needs a hack like GDB did, or could even maybe just do --name-prefix
    or something if Bison-only is OK.
    
    Closes: https://bugs.gentoo.org/866896
    Closes: https://bugs.gentoo.org/915230
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/webkit-gtk/webkit-gtk-2.42.3-r410.ebuild | 5 ++++-
 net-libs/webkit-gtk/webkit-gtk-2.42.3-r600.ebuild | 5 ++++-
 net-libs/webkit-gtk/webkit-gtk-2.42.3.ebuild      | 5 ++++-
 net-libs/webkit-gtk/webkit-gtk-2.42.4-r410.ebuild | 3 +++
 net-libs/webkit-gtk/webkit-gtk-2.42.4-r600.ebuild | 3 +++
 net-libs/webkit-gtk/webkit-gtk-2.42.4.ebuild      | 3 +++
 6 files changed, 21 insertions(+), 3 deletions(-)