Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 866731 - sci-physics/thepeg-2.2.3 passed test suite but did not execute any tests
Summary: sci-physics/thepeg-2.2.3 passed test suite but did not execute any tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Physics related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-26 16:07 UTC by Agostino Sarubbo
Modified: 2022-08-28 07:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,42.35 KB, application/x-xz)
2022-08-26 16:07 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-26 16:07:46 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-physics/thepeg-2.2.3 passed test suite but did not execute any tests.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-26 16:07:48 UTC
Created attachment 801175 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 matoro archtester 2022-08-27 01:39:27 UTC
Working exactly as intended!!!  Tests are conditional on boost being installed.  Needs dev-libs/boost added as test dep.  See snippet from Repository/Makefile.am:

# Compile and use Boost unit tests only if boost unit test libs are available
check_PROGRAMS =
repository_test_SOURCES =
repository_test_LDADD =
repository_test_LDFLAGS =
repository_test_CPPFLAGS =
TESTS =
 
if COND_BOOSTTEST
 THEPEGLDADD = $(top_builddir)/lib/libThePEG.la 
 check_PROGRAMS += repository_test
 repository_test_SOURCES += tests/repositoryTestsMain.cc \
 tests/repositoryTestsGlobalFixture.h \
 tests/repositoryTestRandomGenerator.h
 repository_test_LDADD += $(BOOST_UNIT_TEST_FRAMEWORK_LIBS) $(THEPEGLDADD) $(GSLLIBS) 
 repository_test_LDFLAGS += $(AM_LDFLAGS) -export-dynamic $(BOOST_UNIT_TEST_FRAMEWORK_LDFLAGS) 
 repository_test_CPPFLAGS += $(AM_CPPFLAGS) $(BOOST_CPPFLAGS) -DTHEPEG_PKGLIBDIR="\"$(pkglibdir)\"" -DTHEPEG_PKGDATAD>
 TESTS += repository_test
endif
Comment 3 Larry the Git Cow gentoo-dev 2022-08-27 07:52:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bc2ff4a73f750a84d935bfe8a6a976901c75cc25

commit bc2ff4a73f750a84d935bfe8a6a976901c75cc25
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-08-27 07:52:16 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-08-27 07:52:41 +0000

    sci-physics/thepeg: add test dep: boost
    
    Bug: https://bugs.gentoo.org/866731
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-physics/thepeg/thepeg-2.2.3.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 4 Nowa Ammerlaan gentoo-dev 2022-08-27 07:55:22 UTC
(In reply to matoro from comment #2)
> Working exactly as intended!!!  Tests are conditional on boost being
> installed.  Needs dev-libs/boost added as test dep.  See snippet from
> Repository/Makefile.am:

This is only part of the problem, with boost installed it still does not execute the tests.
Comment 5 matoro archtester 2022-08-27 17:26:18 UTC
(In reply to Andrew Ammerlaan from comment #4)
> (In reply to matoro from comment #2)
> > Working exactly as intended!!!  Tests are conditional on boost being
> > installed.  Needs dev-libs/boost added as test dep.  See snippet from
> > Repository/Makefile.am:
> 
> This is only part of the problem, with boost installed it still does not
> execute the tests.

Okay, I looked into it.  Seems that it needs the same treatment as all the other deps in the configure phase - add $(use_with test boot "${EPREFIX}"/usr) to econf.
Comment 6 Larry the Git Cow gentoo-dev 2022-08-28 07:38:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d60f13ac9278bb42c39b0bc7d34ecb5d094a1eba

commit d60f13ac9278bb42c39b0bc7d34ecb5d094a1eba
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-08-28 07:37:56 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-08-28 07:38:26 +0000

    sci-physics/thepeg: properly build and execute the tests
    
    Closes: https://bugs.gentoo.org/866731
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-physics/thepeg/thepeg-2.2.3.ebuild | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Nowa Ammerlaan gentoo-dev 2022-08-28 07:39:13 UTC
(In reply to matoro from comment #5)
> Okay, I looked into it.  Seems that it needs the same treatment as all the
> other deps in the configure phase - add $(use_with test boot
> "${EPREFIX}"/usr) to econf.

Awesome, that works, thanks for digging into this.