Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 866698 - app-emulation/wine-gecko-2.47.3 version bump (needed for >=app-emulation/wine-*-7.13)
Summary: app-emulation/wine-gecko-2.47.3 version bump (needed for >=app-emulation/wine...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-26 14:43 UTC by Ionen Wolkens
Modified: 2022-08-31 23:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ionen Wolkens gentoo-dev 2022-08-26 14:43:53 UTC
Seems wine been on 2.47.3 for a bit, guess gecko doesn't get used much nowadays (only noticed while testing some rather old installer and got a missing gecko error).

  wine-7.12:#define GECKO_VERSION "2.47.2"
>=wine-7.13:#define GECKO_VERSION "2.47.3"
Comment 1 Tiernan Hubble 2022-08-30 14:18:30 UTC
I got a similar error. I copied "wine-gecko-2.47.2.ebuild" to my local overlay and renamed to "wine-gecko-2.47.3.ebuild" with no changes, and it built successfully and fixed the errors.
Comment 2 Larry the Git Cow gentoo-dev 2022-08-31 22:41:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a8631a0a987ba98d1e64d2d5b9e4aac6f8aa2ed

commit 4a8631a0a987ba98d1e64d2d5b9e4aac6f8aa2ed
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2022-08-31 22:34:52 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2022-08-31 22:41:21 +0000

    app-emulation/wine-vanilla: Update dep
    
    Closes: https://bugs.gentoo.org/866698
    
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 app-emulation/wine-vanilla/wine-vanilla-7.13-r1.ebuild | 2 +-
 app-emulation/wine-vanilla/wine-vanilla-7.13.ebuild    | 2 +-
 app-emulation/wine-vanilla/wine-vanilla-7.14.ebuild    | 2 +-
 app-emulation/wine-vanilla/wine-vanilla-7.15.ebuild    | 2 +-
 app-emulation/wine-vanilla/wine-vanilla-9999.ebuild    | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e18d6dc9e5c1949c9848c734b065ec801bdd4f08

commit e18d6dc9e5c1949c9848c734b065ec801bdd4f08
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2022-08-31 22:37:09 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2022-08-31 22:41:32 +0000

    app-emulation/wine-staging: Update dep
    
    Bug: https://bugs.gentoo.org/866698
    
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 app-emulation/wine-staging/wine-staging-7.12.ebuild    | 2 +-
 app-emulation/wine-staging/wine-staging-7.13-r1.ebuild | 2 +-
 app-emulation/wine-staging/wine-staging-7.13.ebuild    | 2 +-
 app-emulation/wine-staging/wine-staging-7.14.ebuild    | 2 +-
 app-emulation/wine-staging/wine-staging-7.15.ebuild    | 2 +-
 app-emulation/wine-staging/wine-staging-9999.ebuild    | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-31 22:47:37 UTC
I'd suggest something like this in the ebuild:

GECKO_VERSION="2.47.3"
[...]
RDEPEND=">=app-emulation/wine-gecko-${GECKO_VERSION}"
[...]

src_prepare() {
    [...]

    local source_gecko_version=$(grep -Eo '#define GECKO_VERSION "[0-9+]"' ...)
    if [[ ${source_gecko_version} != ${GECKO_VERSION} ]] ; then
        die "Please bump GECKO_VERSION dep!"
    fi
}

or similar. See libmilter for a nice similar example.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-31 22:59:49 UTC
(the regex isn't bang on but you get the idea)
Comment 5 Larry the Git Cow gentoo-dev 2022-08-31 23:22:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=babe14b4c7b77499367cbdca1e811eec66c573fd

commit babe14b4c7b77499367cbdca1e811eec66c573fd
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2022-08-31 23:13:10 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2022-08-31 23:22:23 +0000

    app-emulation/wine-vanilla: Add error for app-emulation/wine-gecko version mismatch
    
    Thanks to sam for basically doing it for me
    
    Bug: https://bugs.gentoo.org/866698
    
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 app-emulation/wine-vanilla/wine-vanilla-7.16.ebuild | 10 +++++++++-
 app-emulation/wine-vanilla/wine-vanilla-9999.ebuild | 10 +++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)