Bug 865677 – dev-python/klein-21.8.0 fails tests

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2022-08-18 10:19:27 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/klein-21.8.0 fails tests (MUSL).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc

[Comment 1 Agostino Sarubbo 2022-08-18 10:19:30 UTC]

Created attachment 800049 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-08-18 10:19:31 UTC]

Error(s) that match a know pattern:


E               AssertionError: Calls not found.
FAILED src/klein/test/test_resource.py::KleinResourceTests::test_addSlash - A...

[Comment 3 Brian Dolbec (RETIRED) 2022-08-18 15:28:48 UTC]

Upstream issue: https://github.com/twisted/klein/issues/563

[Comment 4 Brian Dolbec (RETIRED) 2022-08-27 16:32:28 UTC]

Created attachment 801523 [details]
ebuild

Upstream closed the bug stating to run the tests via twisted.trial NOT pytest.

The updated ebuild fails on my non musl system using both pytest and twisted.trial

So, something has changed since this release was added to the tree as tests were passing at that time.

[Comment 5 Brian Dolbec (RETIRED) 2022-08-27 16:33:50 UTC]

this is my list of currently installed deps:

Calculating dependencies... done!
[ebuild   R    ] dev-python/zope-interface-5.4.0-r2::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/attrs-22.1.0::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/hyperlink-21.0.0-r1::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/incremental-21.3.0-r1::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/werkzeug-2.2.2::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/hypothesis-6.54.4::gentoo  USE="cli -test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/twisted-22.4.0-r2::gentoo  USE="http2 ssl -conch -serial -test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -pypy3 -python3_11" 0 KiB
[ebuild   R    ] dev-python/tubes-0.2.1::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10 -python3_11" 0 KiB
[ebuild   R    ] dev-python/treq-22.2.0-r1::gentoo  USE="-doc -test" PYTHON_TARGETS="python3_8 python3_9 python3_10" 0 KiB
[ebuild   R    ] dev-python/klein-21.8.0-r1::gentoo  USE="-test" PYTHON_TARGETS="python3_8 python3_9 python3_10" 0 KiB

[Comment 6 Matt Whitlock 2022-10-28 13:22:13 UTC]

I also see the test failure on my glibc-based system, but this patch from upstream fixes it:

https://github.com/twisted/klein/commit/bce8b85036a6d185b9e8aab037c805f81354544c


BTW, I'd love to see dev-python/klein updated to support Python 3.11. I have a reverse dependency that is currently blocked from supporting Python 3.11 because dev-python/klein doesn't.

[Comment 7 Larry the Git Cow 2022-10-28 13:34:29 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05d4d793fcf47a04e41cf9b589f17cc81c9c26c1

commit 05d4d793fcf47a04e41cf9b589f17cc81c9c26c1
Author:     Sam James <[e-mail]>
AuthorDate: 2022-10-28 13:34:15 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-10-28 13:34:23 +0000

    dev-python/klein: enable py3.11
    
    Closes: https://bugs.gentoo.org/865677
    Signed-off-by: Sam James <[e-mail]>

 dev-python/klein/klein-21.8.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59678c0886447e0f70c58362f4ba988e5488c7f5

commit 59678c0886447e0f70c58362f4ba988e5488c7f5
Author:     Sam James <[e-mail]>
AuthorDate: 2022-10-28 13:34:00 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-10-28 13:34:22 +0000

    dev-python/treq: enable py3.11
    
    Closes: https://bugs.gentoo.org/865677
    Signed-off-by: Sam James <[e-mail]>

 dev-python/treq/treq-22.2.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a99c289b32c21c8cad1832ef6ddf9581021f682b

commit a99c289b32c21c8cad1832ef6ddf9581021f682b
Author:     Sam James <[e-mail]>
AuthorDate: 2022-10-28 13:29:36 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-10-28 13:34:22 +0000

    dev-python/klein: fix tests
    
    Closes: https://bugs.gentoo.org/865677
    Signed-off-by: Sam James <[e-mail]>

 .../klein/files/klein-21.8.0-test_resource.patch   | 28 ++++++++++++++++++++++
 dev-python/klein/klein-21.8.0.ebuild               |  4 ++++
 2 files changed, 32 insertions(+)

[Comment 8 Matt Whitlock 2022-10-28 13:37:38 UTC]

(In reply to Brian Dolbec from comment #4)
> Created attachment 801523 [details]
> ebuild

@Brian Dolbec: Just a note on ebuild writing: since you're no longer calling distutils_enable_tests in your updated ebuild, you'd need to manually add "test? ( ${RDEPEND} )" to BDEPEND, as the runtime dependencies are required on the build system in order to run the tests on the build system, and you'd need to set RESTRICT="!test? ( test )". distutils_enable_tests normally does both of those things for you.

@Sam James: Thanks for the PYTHON_COMPAT bumps! :)