Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 865455 - Licenses page in devmanual references deprecated PORTDIR
Summary: Licenses page in devmanual references deprecated PORTDIR
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Devmanual Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-17 00:11 UTC by Sam James
Modified: 2024-04-29 18:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-08-17 00:11:15 UTC
Reported by Paul (cc'd) initially via email.

https://devmanual.gentoo.org/general-concepts/licenses/index.html says:
>Finally you need to check if your license should be added to a license group as listed in $PORTDIR/profiles/license_groups.

* The reference to PORTDIR should be changed to 'the repository location' or similar (would need to check what we say elsewhere).

* While at it, we should probably make explicit on the page that packages should not install licenses themselves.
Comment 1 Ulrich Müller gentoo-dev 2022-08-17 06:41:09 UTC
(In reply to Sam James from comment #0)
> * The reference to PORTDIR should be changed to 'the repository location' or
> similar

Suggestion: "... the repository's <c>profiles/license_groups</c> file."

> (would need to check what we say elsewhere).

There are a handful of other places indeed.
Comment 2 Larry the Git Cow gentoo-dev 2024-04-29 18:28:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=700187075bd0827c25eebf48c2460f3bf09ff758

commit 700187075bd0827c25eebf48c2460f3bf09ff758
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-04-29 06:48:37 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-04-29 06:50:48 +0000

    No longer mention PORTDIR
    
    Closes: https://bugs.gentoo.org/865455
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ebuild-writing/functions/src_install/text.xml | 9 ++++-----
 ebuild-writing/variables/text.xml             | 5 ++---
 general-concepts/licenses/text.xml            | 3 ++-
 general-concepts/overlay/text.xml             | 6 +++---
 4 files changed, 11 insertions(+), 12 deletions(-)
Comment 3 Ulrich Müller gentoo-dev 2024-04-29 18:39:17 UTC
(In reply to Sam James from comment #0)
> Reported by Paul (cc'd) initially via email.

Thanks for reporting!