Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 865279 - app-crypt/tpm2-tss-3.2.0-r4 fails tests (lto): <artificial>:(.text+0xc9f): undefined reference to __wrap_tctildr_get_info
Summary: app-crypt/tpm2-tss-3.2.0-r4 fails tests (lto): <artificial>:(.text+0xc9f): un...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Christopher Byrne
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-15 18:26 UTC by Agostino Sarubbo
Modified: 2024-07-06 06:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,38.46 KB, application/x-xz)
2022-08-15 18:27 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-15 18:26:58 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-crypt/tpm2-tss-3.2.0-r4 fails tests (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-15 18:27:01 UTC
Created attachment 799777 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-15 18:27:03 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: <artificial>:(.text+0xd12): undefined reference to `__wrap_tctildr_finalize_data'
<artificial>:(.text+0xc9f): undefined reference to `__wrap_tctildr_get_info'
collect2: error: ld returned 1 exit status
Comment 3 Larry the Git Cow gentoo-dev 2022-09-27 21:44:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e558dc4ed09b71c9114b35e183eedcfd2b5bc61

commit 2e558dc4ed09b71c9114b35e183eedcfd2b5bc61
Author:     Christopher Byrne <salah.coronya@gmail.com>
AuthorDate: 2022-09-26 21:33:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-27 21:42:36 +0000

    app-crypt/tpm2-tss: Filter out LTO flags due test failures
    
    Closes: https://bugs.gentoo.org/865279
    Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/27482
    Signed-off-by: Sam James <sam@gentoo.org>

 app-crypt/tpm2-tss/tpm2-tss-3.2.0-r4.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9a4367ce5c2638979e00095b5c846d5a71326006

commit 9a4367ce5c2638979e00095b5c846d5a71326006
Author:     Christopher Byrne <salah.coronya@gmail.com>
AuthorDate: 2022-09-26 21:30:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-09-27 21:42:36 +0000

    app-crypt/tpm2-tss: Filter out LTO flags due test failures
    
    Closes: https://bugs.gentoo.org/865279
    Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-crypt/tpm2-tss/tpm2-tss-3.2.0-r3.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)