Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 864895 - app-crypt/dehydrated-0.7.0: suggested cron job runs exactly on the hour
Summary: app-crypt/dehydrated-0.7.0: suggested cron job runs exactly on the hour
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marc Schiffbauer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-08-11 10:50 UTC by tastytea
Modified: 2022-08-23 05:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2022-08-11 10:50:48 UTC
The suggested time for the (by default disabled) cron job is 2:00. The Let's 
Encrypt API is often overwhelmed at 2:00 because a lot of people call it exactly
on the hour. It could be misinterpreted as 0:02 on a cursory glance (happened
to me 😄).

While users are responsible for checking that the default makes sense before
activating it, i believe having a reasonable default is worthwhile because it
alleviates the consequences of oversights.

I propose changing the default to something more clear, that is unlikely to fail
even if left unchanged. If the minute is over 24, the room for mistakes shrinks
considerably.
Comment 1 Larry the Git Cow gentoo-dev 2022-08-23 05:24:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=957184a325e39b7a26b24c86b6f5356cc6c0e692

commit 957184a325e39b7a26b24c86b6f5356cc6c0e692
Author:     Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
AuthorDate: 2022-07-15 15:49:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-08-23 05:24:00 +0000

    app-crypt/dehydrated: don't run cron job exactly on the hour
    
    The Let's Encrypt API is often overwhelmed at 2:00 because a lot of
    people call it exactly on the hour. I chose a number over 23 to make
    minutes and hours instantly distinguishable.
    
    Closes: https://bugs.gentoo.org/864895
    Signed-off-by: Ronny (tastytea) Gutbrod <gentoo@tastytea.de>
    Closes: https://github.com/gentoo/gentoo/pull/26420
    Signed-off-by: Sam James <sam@gentoo.org>

 app-crypt/dehydrated/dehydrated-0.7.0-r1.ebuild | 50 +++++++++++++++++++++++++
 app-crypt/dehydrated/files/cron-r1              |  2 +
 2 files changed, 52 insertions(+)