https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: x11-libs/fox-1.6.57-r1 fails to compile (lto). Discovered on: amd64 (internal ref: lto_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 798868 [details] build.log build log and emerge --info
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b1fae4949dd95e2204fd19ee72ca7af8c1816959 commit b1fae4949dd95e2204fd19ee72ca7af8c1816959 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-10-01 08:09:51 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-01 08:37:34 +0000 x11-libs/fox: add 1.7.84 Bug: https://bugs.gentoo.org/864412 Closes: https://bugs.gentoo.org/832299 Signed-off-by: Sam James <sam@gentoo.org> x11-libs/fox/Manifest | 1 + ...7.84-pthread_rwlock_prefer_writer_np-musl.patch | 20 ++++ x11-libs/fox/fox-1.7.84.ebuild | 117 +++++++++++++++++++++ 3 files changed, 138 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04619473f29d5c222d80d607574c222943ef96e5 commit 04619473f29d5c222d80d607574c222943ef96e5 Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-03-08 09:21:50 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-08 11:09:02 +0000 x11-libs/fox: mark as LTO-unsafe, strict-aliasing unsafe Fixed in newer (packaged) version, so only mark the older version, which as it happens is the one with a stable keyword. Closes: https://bugs.gentoo.org/864412 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> x11-libs/fox/fox-1.7.67-r1.ebuild | 10 +++++++++- x11-libs/fox/fox-1.7.67-r2.ebuild | 10 +++++++++- 2 files changed, 18 insertions(+), 2 deletions(-)
*** Bug 928089 has been marked as a duplicate of this bug. ***
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83dc9cfeac977a6577bf9f03bf8fe14c83f095cd commit 83dc9cfeac977a6577bf9f03bf8fe14c83f095cd Author: Eli Schwartz <eschwartz93@gmail.com> AuthorDate: 2024-04-03 21:04:05 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-04-05 01:20:49 +0000 x11-libs/fox: also mark oldest version as LTO-unsafe It has a different slot. Bug: https://bugs.gentoo.org/864412 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> x11-libs/fox/fox-1.6.57-r3.ebuild | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=422109dcf6f391736093a4346ec6b7e41be497ac commit 422109dcf6f391736093a4346ec6b7e41be497ac Author: Sam James <sam@gentoo.org> AuthorDate: 2024-10-09 10:41:28 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-10-09 10:41:28 +0000 x11-libs/fox: consistently pass -fno-strict-aliasing It's not fixed in 1.7.84, they've just papered over it, see fe5777553eb7e9cf64c0526ba194b831cb455f38 where I quote the upstream site. Bug: https://bugs.gentoo.org/864412 Closes: https://bugs.gentoo.org/940648 Signed-off-by: Sam James <sam@gentoo.org> x11-libs/fox/fox-1.6.57-r3.ebuild | 5 +---- x11-libs/fox/fox-1.7.67-r1.ebuild | 5 +---- x11-libs/fox/fox-1.7.67-r2.ebuild | 5 +---- x11-libs/fox/fox-1.7.84.ebuild | 3 +++ 4 files changed, 6 insertions(+), 12 deletions(-)
