Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 863737 - sys-cluster/torque-6.0.4-r6 fails to compile (lto): pbs_job.h:663:8: error: type struct jo violates the C++ One Definition Rule [-Werror=odr]
Summary: sys-cluster/torque-6.0.4-r6 fails to compile (lto): pbs_job.h:663:8: error: t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Cluster Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-05 07:10 UTC by Agostino Sarubbo
Modified: 2024-08-12 03:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,377.05 KB, text/plain)
2022-08-05 07:10 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-05 07:10:30 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-cluster/torque-6.0.4-r2 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-05 07:10:33 UTC
Created attachment 797839 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-05 07:10:35 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


./configure: line 19156: ac_fn_c_check_member: command not found
cat: current_hash: No such file or directory
fatal: not a git repository (or any parent up to mount point /var/tmp)
../../src/include/pbs_job.h:663:8: error: type 'struct job' violates the C++ One Definition Rule [-Werror=odr[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wodr]]
Comment 3 Agostino Sarubbo gentoo-dev 2024-03-27 08:03:05 UTC
lto_tinderbox has reproduced this issue with version 6.0.4-r6 - Updating summary.
Comment 4 Larry the Git Cow gentoo-dev 2024-08-12 03:29:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=10f6df4224f83524bf5cd3cf38d1b2f9c4ab8faa

commit 10f6df4224f83524bf5cd3cf38d1b2f9c4ab8faa
Author:     Eli Schwartz <eschwartz@gentoo.org>
AuthorDate: 2024-08-12 01:49:51 +0000
Commit:     Eli Schwartz <eschwartz@gentoo.org>
CommitDate: 2024-08-12 03:29:35 +0000

    sys-cluster/torque: mark as LTO-unsafe
    
    The project appears to have gone source-unavailable and all-in on AI.
    There are 6.x versions available mysteriously as some git branch with no
    distfiles (Fedora packages this) and a 7.x version is announced on their
    website but you have to contact sales to find out more. They haven't
    communicated on github in years.
    
    Not only is reporting a bug an exercise in futility, I'm not super
    interested in trying to begin with.
    
    Closes: https://bugs.gentoo.org/863737
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>

 sys-cluster/torque/torque-6.0.4-r6.ebuild | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)