Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 863713 - sys-apps/texinfo-6.8 fails to compile (lto): error.h:33:13: error: type of [-Werror=lto-type-mismatch]
Summary: sys-apps/texinfo-6.8 fails to compile (lto): error.h:33:13: error: type of [-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://lists.gnu.org/archive/html/bu...
Whiteboard:
Keywords:
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-05 07:07 UTC by Agostino Sarubbo
Modified: 2022-12-29 01:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,129.21 KB, text/plain)
2022-08-05 07:07 UTC, Agostino Sarubbo
Details
buildlog (build.log,90.15 KB, text/plain)
2022-12-07 20:08 UTC, Kostadin Shishmanov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-05 07:07:31 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/texinfo-6.8 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-05 07:07:33 UTC
Created attachment 797815 [details]
build.log

build log and emerge --info
Comment 2 Larry the Git Cow gentoo-dev 2022-10-20 03:50:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a5b8af6d6b24d4794fc626971972e1714a52365

commit 0a5b8af6d6b24d4794fc626971972e1714a52365
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-20 03:32:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-20 03:43:03 +0000

    sys-apps/texinfo: add 6.8.90 ("pretest", unkeyworded)
    
    Bug: https://bugs.gentoo.org/574740
    Bug: https://bugs.gentoo.org/624394
    Bug: https://bugs.gentoo.org/679238
    Bug: https://bugs.gentoo.org/863713
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/texinfo/Manifest              |  1 +
 sys-apps/texinfo/texinfo-6.8.90.ebuild | 62 ++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-11-08 02:40:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9be8b3c99b95b29ec1f233736840cfa83400f617

commit 9be8b3c99b95b29ec1f233736840cfa83400f617
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-11-08 02:38:36 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-11-08 02:39:33 +0000

    sys-apps/texinfo: add 7.0, drop 6.8.91
    
    Closes: https://bugs.gentoo.org/574740
    Closes: https://bugs.gentoo.org/624394
    Closes: https://bugs.gentoo.org/679238
    Closes: https://bugs.gentoo.org/863713
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/texinfo/Manifest                                      | 2 +-
 sys-apps/texinfo/{texinfo-6.8.91.ebuild => texinfo-7.0.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 4 Kostadin Shishmanov 2022-12-07 20:08:45 UTC
Created attachment 840847 [details]
buildlog

I am still running into this on sys-apps/texinfo-7.0.1
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-12-07 21:06:53 UTC
(In reply to Kostadin from comment #4)
> Created attachment 840847 [details]
> buildlog
> 
> I am still running into this on sys-apps/texinfo-7.0.1

Thanks, reported upstream: https://lists.gnu.org/archive/html/bug-texinfo/2022-12/msg00034.html.
Comment 6 Larry the Git Cow gentoo-dev 2022-12-29 01:14:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef0f2d0c1e074d48a6272a646dd0cb7f0605d160

commit ef0f2d0c1e074d48a6272a646dd0cb7f0605d160
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-29 01:13:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-29 01:13:59 +0000

    sys-apps/texinfo: backport LTO & crash fixes
    
    From 7.0.1 branch.
    
    Closes: https://bugs.gentoo.org/863713
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/texinfo-7.0.1-info-groff-crash.patch     | 44 ++++++++++++++
 .../files/texinfo-7.0.1-lto-type-mismatch.patch    | 31 ++++++++++
 sys-apps/texinfo/texinfo-7.0.1-r1.ebuild           | 67 ++++++++++++++++++++++
 3 files changed, 142 insertions(+)