Created attachment 797656 [details, diff] proposed changes The attached patch does the following: - Fix copypasta longdescription in metadata.xml - Fix HOMEPAGE and SRC_URI - Remove python dependency: there is no python involved in suil. For building the docs, the dependency should be fine (?) - add gtk2 useflag and dependencies - add X useflag and dependencies - Add missing Qt5 dependencies - simplify dependencies management Tested with pkgdev manifest, pkgcheck scan --net and qa-vdb suil I can also open a pull request on github if that helps.
It is good to fix bogus IUSE=gtk ( x11-libs/gtk+:2 ) enabling $(meson_feature gtk gtk3) but please do not introduce new gtk+:2 dependencies at this point anymore.
(In reply to Andreas Sturmlechner from comment #1) > It is good to fix bogus IUSE=gtk ( x11-libs/gtk+:2 ) enabling > $(meson_feature gtk gtk3) but please do not introduce new gtk+:2 > dependencies at this point anymore. Sadly Ardour, one of the major DAW, is still using gtk+:2 and as such gtk2 support in suil is much needed. In the past, the devs stated their lack of interest in updating :( Btw if this gets merged, the dependency in media-sound/ardour must be adjusted to media-libs/suil[gtk2]
(In reply to Olivier Huber from comment #2) > Sadly Ardour, one of the major DAW, is still using gtk+:2 and as such gtk2 > support in suil is much needed. How does that even work right now, since IUSE=gtk is actually enabling gtk3?
(In reply to Andreas Sturmlechner from comment #3) > (In reply to Olivier Huber from comment #2) > > Sadly Ardour, one of the major DAW, is still using gtk+:2 and as such gtk2 > > support in suil is much needed. > How does that even work right now, since IUSE=gtk is actually enabling gtk3? The build system detects gtk+:2 and enables the module
Created attachment 799651 [details, diff] changes for suil 0.10.16 suil 0.10.16 was added to the tree, updating the patch
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=690b0c79e8f921246347194e62a9a6de6b35ea85 commit 690b0c79e8f921246347194e62a9a6de6b35ea85 Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2022-09-18 13:17:08 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2022-09-18 13:34:28 +0000 media-libs/suil: improvements to 0.10.16 - Fix copypasta longdescription in metadata.xml - Fix HOMEPAGE and SRC_URI - Remove python dependency: there is no python involved in suil. For building the docs, the dependency should be fine (?) - add gtk2 useflag and dependencies - add X useflag and dependencies - Add missing Qt5 dependencies - simplify dependencies managemen Patch by Olivier Huber <oli.huber@gmail.com> Closes: https://bugs.gentoo.org/863614 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-libs/suil/metadata.xml | 18 +++++++---- ...{suil-0.10.16.ebuild => suil-0.10.16-r1.ebuild} | 37 ++++++++++++++-------- 2 files changed, 34 insertions(+), 21 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b92a8a2f9a01b5ca49218444ab133e887c7ccfec commit b92a8a2f9a01b5ca49218444ab133e887c7ccfec Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2022-09-18 13:34:02 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2022-09-18 13:34:28 +0000 media-sound/ardour: updated python versions, dropped eutils.eclass, updated to changes in media-libs/suil Bug: https://bugs.gentoo.org/863614 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/ardour/ardour-6.9-r2.ebuild | 6 +++--- media-sound/ardour/ardour-9999.ebuild | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
