Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 863053 - sci-mathematics/nauty-2.7.3 installs pkg-config files with mismatched Version
Summary: sci-mathematics/nauty-2.7.3 installs pkg-config files with mismatched Version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Mathematics related packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: pkg-config_mismatched-version
  Show dependency tree
 
Reported: 2022-08-02 14:09 UTC by Agostino Sarubbo
Modified: 2022-08-11 11:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,199.29 KB, text/plain)
2022-08-02 14:09 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-02 14:09:11 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-mathematics/nauty-2.7.3 installs pkg-config files with mismatched Version.
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-02 14:09:14 UTC
Created attachment 796900 [details]
build.log

build log and emerge --info
Comment 2 Michael Orlitzky gentoo-dev 2022-08-11 00:17:05 UTC
Reported upstream at,

  https://mailman.anu.edu.au/pipermail/nauty/2022-August/000899.html

and waiting with my fingers crossed for a sane versioning scheme.
Comment 3 Larry the Git Cow gentoo-dev 2022-08-11 11:50:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95f19838fef64c346e780e46937f0ae0eed5a6a2

commit 95f19838fef64c346e780e46937f0ae0eed5a6a2
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2022-08-11 11:30:32 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2022-08-11 11:49:51 +0000

    sci-mathematics/nauty: add 2.7.4
    
    This version also modifies the nauty.pc file to report the same version
    information that the ebuild contains. This is one of a few bad choices
    we're bequeathed from the crazy upstream versioning scheme; it probably
    does no harm and makes the QA warning go away.
    
    Closes: https://bugs.gentoo.org/863053
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/nauty/Manifest           |  2 +
 sci-mathematics/nauty/nauty-2.7.4.ebuild | 83 ++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+)