Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862912 - sci-libs/opencascade-7.7.0-r2 fails to compile (lto): XCAFDoc_Datum.cxx:37:6: error: type ChildLab violates the C++ One Definition Rule [-Werror=odr]
Summary: sci-libs/opencascade-7.7.0-r2 fails to compile (lto): XCAFDoc_Datum.cxx:37:6:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paul Zander
URL:
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-02 06:59 UTC by Agostino Sarubbo
Modified: 2024-03-26 20:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,165.60 KB, application/x-xz)
2022-08-02 06:59 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-02 06:59:01 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/opencascade-7.6.2-r1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-02 06:59:05 UTC
Created attachment 796759 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-02 06:59:07 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: lin64/gcc/libi/libTKXCAF.so.7.6.2 
/var/tmp/portage/sci-libs/opencascade-7.6.2-r1/work/occt-V7_6_2/src/XCAFDoc/XCAFDoc_Datum.cxx:37:6: error: type ‘ChildLab’ violates the C++ One Definition Rule [-Werror=odr]
Comment 3 Agostino Sarubbo gentoo-dev 2024-03-23 09:41:25 UTC
lto_tinderbox has reproduced this issue with version 7.7.0-r2 - Updating summary.
Comment 4 Eli Schwartz 2024-03-26 19:03:22 UTC
Still reproducible at -9999 today.
Comment 5 Larry the Git Cow gentoo-dev 2024-03-26 20:25:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=701bc30b5e597655e5cdf02a74c64836333b61e3

commit 701bc30b5e597655e5cdf02a74c64836333b61e3
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-03-26 19:02:35 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-26 20:23:27 +0000

    sci-libs/opencascade: mark as LTO-unsafe
    
    Closes: https://bugs.gentoo.org/862912
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/opencascade/opencascade-7.7.0-r2.ebuild | 7 ++++++-
 sci-libs/opencascade/opencascade-7.7.1.ebuild    | 7 ++++++-
 sci-libs/opencascade/opencascade-7.7.2.ebuild    | 7 ++++++-
 sci-libs/opencascade/opencascade-7.8.0.ebuild    | 7 ++++++-
 sci-libs/opencascade/opencascade-9999.ebuild     | 7 ++++++-
 5 files changed, 30 insertions(+), 5 deletions(-)