Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862900 - sci-libs/med-4.1.1 fails to compile (lto): medmesh.f:1373:72: error: type of mmhfasr does not match original declaration [-Werror=lto-type-mismatch]
Summary: sci-libs/med-4.1.1 fails to compile (lto): medmesh.f:1373:72: error: type of ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: lto
  Show dependency tree
 
Reported: 2022-08-02 06:57 UTC by Agostino Sarubbo
Modified: 2022-08-23 12:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,51.60 KB, application/x-xz)
2022-08-02 06:57 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-02 06:57:24 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/med-4.1.1 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-02 06:57:27 UTC
Created attachment 796747 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-02 06:57:30 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: src/libmedfwrap.so.11.1.1 
/var/tmp/portage/sci-libs/med-4.1.1/work/med-4.1.1_SRC/src/fi/medmesh.f:1373:72: error: type of ‘mmhfasr’ does not match original declaration [-Werror=lto-type-mismatch]
Comment 3 Bernd 2022-08-05 14:55:04 UTC
See also https://discourse.salome-platform.org/t/build-issue-with-medfile-and-lto-werror-lto-type-mismatch/323/2 which seems no valid URL for the see also input field.
Comment 4 Larry the Git Cow gentoo-dev 2022-08-23 12:12:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2ff013eccf3957a6a0980005fb0a3eb6745dfce

commit c2ff013eccf3957a6a0980005fb0a3eb6745dfce
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2022-08-10 15:37:37 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-08-23 12:09:37 +0000

    sci-libs/med: filter lto flags
    
    Closes: https://bugs.gentoo.org/862900
    Bug: https://discourse.salome-platform.org/t/build-issue-with-medfile-and-lto-werror-lto-type-mismatch/323/2
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/26813
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-libs/med/med-4.1.1.ebuild | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)