https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-action/blackvoxel-2.50 fails to compile (lto). Discovered on: amd64 (internal ref: guru_tinderbox) NOTE: This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Created attachment 796519 [details] build.log build log and emerge --info
Hi, do you still have this issue? The game compiles just fine on my end.
Looks like it was fixed upstream by https://github.com/Blackvoxel/Blackvoxel/commit/f891808f14458691933301058daa6b7f8f994a53. That patch is not in a tag though, so it needs to be backported. (In reply to Abdul from comment #2) > Hi, do you still have this issue? > The game compiles just fine on my end. You'll only hit this if using -Werror=x for LTO safety per https://wiki.gentoo.org/wiki/Project:Toolchain/LTO.
>Looks like it was fixed upstream by https://github.com/Blackvoxel/Blackvoxel/commit/f891808f14458691933301058daa6b7f8f994a53. That patch is not in a tag though, so it needs to be backported. Alright. I will be back porting it later today.
I got it all working, but one of the patches succeeds with fuzz 1. Is that acceptable?
Alright, I finally fixed it. Will be sending the patch shortly.
I sent the patch
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=37432fa0182129180bd122f31b85df320b5fa7d7 commit 37432fa0182129180bd122f31b85df320b5fa7d7 Author: Abdelrahman Sarhan <abdulrahmanayman1@gmail.com> AuthorDate: 2024-10-21 22:06:21 +0000 Commit: Abdelrahman Sarhan <abdulrahmanayman1@gmail.com> CommitDate: 2024-10-21 22:06:21 +0000 games-action/blackvoxel:-Werror=strict-aliasing & makeopts patch fix Closes: https://bugs.gentoo.org/862780 Signed-off-by: Abdelrahman Sarhan <abdulrahmanayman1@gmail.com> games-action/blackvoxel/blackvoxel-2.50.ebuild | 2 +- ...ct-aliasing.patch => blackvoxel-2.50-backported-ltofix.patch} | 0 games-action/blackvoxel/files/blackvoxel-2.50-makeopts.patch | 9 +++++---- 3 files changed, 6 insertions(+), 5 deletions(-)
